From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>,
stable <stable@vger.kernel.org>
Subject: Re: FAILED: patch "[PATCH] pipe: increase minimum default pipe size to 2 pages" failed to apply to 4.4-stable tree
Date: Tue, 10 Aug 2021 08:54:13 +0200 [thread overview]
Message-ID: <YRIilQUgbcejSREr@kroah.com> (raw)
In-Reply-To: <20210809190406.GA23706@1wt.eu>
On Mon, Aug 09, 2021 at 09:04:06PM +0200, Willy Tarreau wrote:
> On Mon, Aug 09, 2021 at 07:40:41PM +0200, Greg Kroah-Hartman wrote:
> > > fs/pipe.c | 17 ++++++++++++++++-
> > > 1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > This looks good to me, I'll queue it up in a bit as it's more
> > descriptive than Alex's backport.
>
> Greg, do you *really* want to backport it to 4.4 ? I mean, if nobody
> faces this issue in 4.4 I can see more risks with the fix that without
> for systems with low memory (or manually tuned memory usage).
I always prefer to merge "known fixes" to the stable kernel trees as
somehow once one person hits a bug, everyone hits it, no matter how long
it was in hiding :)
The additional memory usage here seems low to me, and we backported the
needed accounting changes there a long time ago, and we know that 4.4.y
is being used for build servers as well as other huge hosting providers.
The "tiny" systems that might be on 4.4 are not really updating
themselves to newer kernels from what I can tell.
So I would prefer to take this patch, but am always willing to revert it
if someone reports problems with it, as it keeps us in sync with the
other stable branches, and with upstream, as close as possible.
thanks,
greg k-h
next prev parent reply other threads:[~2021-08-10 6:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 9:52 FAILED: patch "[PATCH] pipe: increase minimum default pipe size to 2 pages" failed to apply to 4.4-stable tree gregkh
2021-08-09 16:23 ` Linus Torvalds
2021-08-09 16:27 ` Greg Kroah-Hartman
2021-08-09 16:36 ` Linus Torvalds
2021-08-09 16:46 ` Linus Torvalds
2021-08-09 17:40 ` Greg Kroah-Hartman
2021-08-09 19:04 ` Willy Tarreau
2021-08-10 6:54 ` Greg Kroah-Hartman [this message]
2021-08-10 8:39 ` Willy Tarreau
2021-08-09 16:51 ` Alex Xu (Hello71)
2021-08-09 16:57 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRIilQUgbcejSREr@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex_y_xu@yahoo.ca \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox