From: Greg KH <greg@kroah.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: stable@vger.kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH 4.19.y] tracing: Reject string operand in the histogram expression
Date: Fri, 13 Aug 2021 10:37:27 +0200 [thread overview]
Message-ID: <YRYvR9VVL3W64KVW@kroah.com> (raw)
In-Reply-To: <162866758593.360697.15659863374890557625.stgit@devnote2>
On Wed, Aug 11, 2021 at 04:39:46PM +0900, Masami Hiramatsu wrote:
> commit a9d10ca4986571bffc19778742d508cc8dd13e02 upstream
>
> Since the string type can not be the target of the addition / subtraction
> operation, it must be rejected. Without this fix, the string type silently
> converted to digits.
>
> Link: https://lkml.kernel.org/r/162742654278.290973.1523000673366456634.stgit@devnote2
>
> Cc: stable@vger.kernel.org
> Fixes: 100719dcef447 ("tracing: Add simple expression support to hist triggers")
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> - Since there is no hist_err() APIs in 4.19, this just check the flag
> and return an error without any error messages.
> ---
> kernel/trace/trace_events_hist.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
Both backports applied, thanks.
greg k-h
prev parent reply other threads:[~2021-08-13 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 9:14 FAILED: patch "[PATCH] tracing: Reject string operand in the histogram expression" failed to apply to 4.19-stable tree gregkh
2021-08-11 7:39 ` [PATCH 4.19.y] tracing: Reject string operand in the histogram expression Masami Hiramatsu
2021-08-13 8:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRYvR9VVL3W64KVW@kroah.com \
--to=greg@kroah.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox