From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F7CC4338F for ; Fri, 13 Aug 2021 08:37:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2556660F51 for ; Fri, 13 Aug 2021 08:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239235AbhHMIh6 (ORCPT ); Fri, 13 Aug 2021 04:37:58 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:59737 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239196AbhHMIh5 (ORCPT ); Fri, 13 Aug 2021 04:37:57 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id B2133320091F; Fri, 13 Aug 2021 04:37:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 13 Aug 2021 04:37:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=JMaEU/ORw/600wLh1FpgOn1R9xx gHjAbfX8/Za0rJJQ=; b=C4OkcyAhymcy2iTF39wRmSKCdN75ZXZ+ywSCEZRRwdI 51f7gL9lB7CjRMG55COWVwm+xbdtDxMDggpGMnQZl8CBox4o59iW5XtUHjE6ZrZt MpzKB3Qi7C/qjIm+vWZiU8nrHTIBUrTTLl/KHkcMXk3fvoHaFcmPwc1jGcPf8mAM 6rGOAjaq6otoIWa62Yi8fItLRdB7MfX0yaG53kkPku1q9w5dbB8HWlczRzbO1biT iIECS2sYlbFF8CeWkKQT7IS2svro6y6pG1JKQMqCeSVvqpiPLxY5qCTC4fBY46Rm jseM+b9nTv82jTOinBQI7P6XgS8TqA4gzSdzE5oQUEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=JMaEU/ ORw/600wLh1FpgOn1R9xxgHjAbfX8/Za0rJJQ=; b=mOkE9NPjUS5glxpdCPWqYH uJNx1kAokn2b0MnHamJEhkpgh3Wo7OKhw3aAXR3VhTj/msUNjqo2WuxA53JGIzG+ EzpkpIZhehCBNrv/DxFSE91qu8j3GFxNw53kWP7JmSo0LaLjMlrtpWBRgccIZlow nxonJwb9DSOuzu1x+7nulHRaPqysm3DyTeGsr18UU3yMlrpP7fMew1EPTgSy05to wLQfLEPsYqoC2Ct5CueRWQ5kF95w/tr+l/uJAl/q0LRoPnfe3DCb+QbuHunEhnRt ERaImRUcX6AFJdnZpuRq1nU6ynCWxdwMu4p4Amj8ODGYVp7rfy4mYtJzBiXmnIvA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrkeehgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepueelledthe ekleethfeludduvdfhffeuvdffudevgeehkeegieffveehgeeftefgnecuffhomhgrihhn pehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Aug 2021 04:37:29 -0400 (EDT) Date: Fri, 13 Aug 2021 10:37:27 +0200 From: Greg KH To: Masami Hiramatsu Cc: stable@vger.kernel.org, rostedt@goodmis.org Subject: Re: [PATCH 4.19.y] tracing: Reject string operand in the histogram expression Message-ID: References: <162850048982205@kroah.com> <162866758593.360697.15659863374890557625.stgit@devnote2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162866758593.360697.15659863374890557625.stgit@devnote2> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Aug 11, 2021 at 04:39:46PM +0900, Masami Hiramatsu wrote: > commit a9d10ca4986571bffc19778742d508cc8dd13e02 upstream > > Since the string type can not be the target of the addition / subtraction > operation, it must be rejected. Without this fix, the string type silently > converted to digits. > > Link: https://lkml.kernel.org/r/162742654278.290973.1523000673366456634.stgit@devnote2 > > Cc: stable@vger.kernel.org > Fixes: 100719dcef447 ("tracing: Add simple expression support to hist triggers") > Signed-off-by: Masami Hiramatsu > Signed-off-by: Steven Rostedt (VMware) > --- > - Since there is no hist_err() APIs in 4.19, this just check the flag > and return an error without any error messages. > --- > kernel/trace/trace_events_hist.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Both backports applied, thanks. greg k-h