From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D9AC4338F for ; Tue, 17 Aug 2021 16:06:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A4256054E for ; Tue, 17 Aug 2021 16:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229723AbhHQQGs (ORCPT ); Tue, 17 Aug 2021 12:06:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:59882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbhHQQGr (ORCPT ); Tue, 17 Aug 2021 12:06:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 37A6E6054E; Tue, 17 Aug 2021 16:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629216373; bh=NZw4XOoUWEfRHscEvAAAadavXr/gyDCjshgThc1nlFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OFxlu6NbyMlgKUgxMf/C9sULXfJYGWkLXxXoVtniNNnDGWCR3uV7Y8qchBdXdpw5+ 5lAiVS5J+BSGWv0gq3SB7qqfbwPC26o/3MMEvxL4RkjhWx5hgWnP+EcQMsnrQnOH+Z 1qA54H9qarwFrA6Jzs5aRd+hYLQf5x6nmBYaguD4= Date: Tue, 17 Aug 2021 18:06:10 +0200 From: Greg KH To: Petko Manolov Cc: netdev@vger.kernel.org, kuba@kernel.org, paskripkin@gmail.com, stable@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH] net: usb: pegasus: fixes of set_register(s) return value evaluation; Message-ID: References: <20210817140613.27737-1-petko.manolov@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210817140613.27737-1-petko.manolov@konsulko.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Aug 17, 2021 at 05:06:13PM +0300, Petko Manolov wrote: > - restore the behavior in enable_net_traffic() to avoid regressions - Jakub > Kicinski; > - hurried up and removed redundant assignment in pegasus_open() before yet > another checker complains; > - explicitly check for negative value in pegasus_set_wol(), even if > usb_control_msg_send() never return positive number we'd still be in sync > with the rest of the driver style; > > Signed-off-by: Petko Manolov > --- > drivers/net/usb/pegasus.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.