From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F22C432BE for ; Thu, 2 Sep 2021 13:52:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AD4F610A0 for ; Thu, 2 Sep 2021 13:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234331AbhIBNw5 (ORCPT ); Thu, 2 Sep 2021 09:52:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:35134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230473AbhIBNw4 (ORCPT ); Thu, 2 Sep 2021 09:52:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E270610A1; Thu, 2 Sep 2021 13:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630590717; bh=dgIzmPo1P6m2cyM7pyKV1/gksgOBtehkPWZag/5Vm6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WlRyCrDfyqg/IC3joO7zvX3DBgpe35Fqn5W+UZB/Ra0RC1kJpbjjPriXozRfNOja8 Zjicp2Dd4n5vCgIyrykcuK246FDkVuQApg06lPZJaY4HQokZMOo3oz81Omq83XJUYo zSp15enInSRmjp7wBTKxbcRpApjMHMyPMWtnrAN/zyh6VgHy2TYj/grT/ZD7jrZTb1 bGbmjgBoQuDHsdcAlnzzUn52Ct82P36yQO/OWA/kZJSl0tf8AI6ba6c3q+GvS2ZB2Q XfP6CgvSGLkDinK6Z68A5zkPUlv3GD1zjJlmxe49vBgI3qEIbxe/VPblcKJ1z/iP5H V08PuN7GOfCnQ== Date: Thu, 2 Sep 2021 09:51:56 -0400 From: Sasha Levin To: Pavel Machek Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Xiaoliang Yang , "David S. Miller" Subject: Re: [PATCH 5.10 047/103] net: stmmac: add mutex lock to protect est parameters Message-ID: References: <20210901122300.503008474@linuxfoundation.org> <20210901122302.156121465@linuxfoundation.org> <20210901200953.GB8962@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210901200953.GB8962@duo.ucw.cz> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Sep 01, 2021 at 10:09:53PM +0200, Pavel Machek wrote: >Hi! > >> [ Upstream commit b2aae654a4794ef898ad33a179f341eb610f6b85 ] >> >> Add a mutex lock to protect est structure parameters so that the >> EST parameters can be updated by other threads. > >Mainline version of the patch is okay, but I believe we need one more >mutex_unlock in 5.10. I think you're right. Looks like it's because we don't have 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure") in 5.10 (and I don't think it makes sense to backport it either). I've squashed your patch into the backport, thanks! -- Thanks, Sasha