From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B90C433EF for ; Thu, 9 Sep 2021 05:42:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7EDF61167 for ; Thu, 9 Sep 2021 05:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232356AbhIIFoE (ORCPT ); Thu, 9 Sep 2021 01:44:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:34314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230515AbhIIFoE (ORCPT ); Thu, 9 Sep 2021 01:44:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 782C761158; Thu, 9 Sep 2021 05:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631166175; bh=r9o1CP4+B7HBUCKSiENG0NPcrypHvY9dY0wYuuke0sA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nCNQjT6zf4C6XVa8EEopbGip4FGZOKbtusEUVgIfNaHCmIxwQi9kJQ8iQkEwy7Qzh z3LmSet1HIh7HdcVoyqpDUZGFVDaUCo7BcG+hAWPBBIcrb0HqHeaEsFaCwEXW5MPQ4 h8zCGi/2azd60XmjXnV/tdZlS2fwR3cUBeLCyQXXMbXhiqlRoSI6hA3oL36VGaRrp9 /azXWvcceir4qBowTh7C75j9j1ecuLgJezj2dA6eNAL++y4YFQCslVvLwSlOh4agx3 Yjn5CEAPZVOU5P/Lf9mIL3nY72Pw2CC1e3sqREDNW4FRB9XsYTcgyNL96UPEPw77ab muNrSQQIUANDw== Date: Wed, 8 Sep 2021 22:42:53 -0700 From: Jaegeuk Kim To: Greg KH Cc: stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Chao Yu Subject: Re: [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back Message-ID: References: <20210908220020.599899-1-jaegeuk@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 09/09, Greg KH wrote: > On Wed, Sep 08, 2021 at 10:28:37PM -0700, Jaegeuk Kim wrote: > > On 09/09, Greg KH wrote: > > > On Wed, Sep 08, 2021 at 03:00:20PM -0700, Jaegeuk Kim wrote: > > > > From: Jaegeuk Kim > > > > > > > > commit dddd3d65293a52c2c3850c19b1e5115712e534d8 upstream. > > > > > > > > We must flush all the dirty data when enabling checkpoint back. Let's guarantee > > > > that first by adding a retry logic on sync_inodes_sb(). In addition to that, > > > > this patch adds to flush data in fsync when checkpoint is disabled, which can > > > > mitigate the sync_inodes_sb() failures in advance. > > > > > > > > Reviewed-by: Chao Yu > > > > Signed-off-by: Jaegeuk Kim > > > > --- > > > > fs/f2fs/file.c | 5 ++--- > > > > fs/f2fs/super.c | 11 ++++++++++- > > > > 2 files changed, 12 insertions(+), 4 deletions(-) > > > > > > What stable kernel(s) are you wanting to have this backported to? > > > > 5.10 please. > > Why would you want to skip 5.14.y and 5.13.y? You never want anyone to > upgrade stable kernel releases and have a regression. I was just looking at the essential kernel version, since the fix is only related to checkpoint=disable feature used in android only. Feel free to merge it into any stable kernels if you want. > > thanks, > > greg k-h