From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7994C433F5 for ; Thu, 9 Sep 2021 06:09:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF09C61179 for ; Thu, 9 Sep 2021 06:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350968AbhIIGKQ (ORCPT ); Thu, 9 Sep 2021 02:10:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:44236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231438AbhIIGKQ (ORCPT ); Thu, 9 Sep 2021 02:10:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0FA5561176; Thu, 9 Sep 2021 06:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631167747; bh=yvjgmxybSsnsnCQKpzwUQ53dsvC/6l4aZ3Bu0jatUPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jkKNBXgL9g++cwgdNYvdwxLOLZokkzBbwl7Xz+tGjFCH4Zrho3tAAv7odaajips+6 6bvPEorNDfM7OtaO8RiQn2IsMGY5+QOuoAL37ym2If4brKTZev/1N/pj163XMCsH+V QhPq1Qd+r6aOhMGFZCDrW1EvAhjVz6dUqYtq1j0E= Date: Thu, 9 Sep 2021 08:09:05 +0200 From: Greg KH To: Jaegeuk Kim Cc: stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Chao Yu Subject: Re: [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back Message-ID: References: <20210908220020.599899-1-jaegeuk@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Sep 08, 2021 at 10:42:53PM -0700, Jaegeuk Kim wrote: > On 09/09, Greg KH wrote: > > On Wed, Sep 08, 2021 at 10:28:37PM -0700, Jaegeuk Kim wrote: > > > On 09/09, Greg KH wrote: > > > > On Wed, Sep 08, 2021 at 03:00:20PM -0700, Jaegeuk Kim wrote: > > > > > From: Jaegeuk Kim > > > > > > > > > > commit dddd3d65293a52c2c3850c19b1e5115712e534d8 upstream. > > > > > > > > > > We must flush all the dirty data when enabling checkpoint back. Let's guarantee > > > > > that first by adding a retry logic on sync_inodes_sb(). In addition to that, > > > > > this patch adds to flush data in fsync when checkpoint is disabled, which can > > > > > mitigate the sync_inodes_sb() failures in advance. > > > > > > > > > > Reviewed-by: Chao Yu > > > > > Signed-off-by: Jaegeuk Kim > > > > > --- > > > > > fs/f2fs/file.c | 5 ++--- > > > > > fs/f2fs/super.c | 11 ++++++++++- > > > > > 2 files changed, 12 insertions(+), 4 deletions(-) > > > > > > > > What stable kernel(s) are you wanting to have this backported to? > > > > > > 5.10 please. > > > > Why would you want to skip 5.14.y and 5.13.y? You never want anyone to > > upgrade stable kernel releases and have a regression. > > I was just looking at the essential kernel version, since the fix is only > related to checkpoint=disable feature used in android only. Feel free to > merge it into any stable kernels if you want. No regressions for any stable releases is key here, Android is just one user of the kernel... And in the future, just put a cc: stable in the signed-off-by area when you submit the patch and it will be handled automatically, like the documentation states :) thanks, greg k-h