From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6390C433F5 for ; Wed, 15 Sep 2021 13:00:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 857BC61356 for ; Wed, 15 Sep 2021 13:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233255AbhIONCB (ORCPT ); Wed, 15 Sep 2021 09:02:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:40488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233238AbhIONCB (ORCPT ); Wed, 15 Sep 2021 09:02:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F314961355; Wed, 15 Sep 2021 13:00:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631710842; bh=HzmARJHOWjJAgObx4+6ScKwdV/y3UM/9zWgBL6v1qIE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TzSG5HT/nA0aV7qxqbla+EeVLteVr2gezG+jhL8aQdP+KK2aGP5mEJ6ibF+Nr3TMG IeA9UuSsfYESuOuRkQlV+Xw6nnlXhEOxMH97WmDxwuLTJBLB6jBYqAK+LCdoQ1FsXJ E+Y+QyvVbODvjET8sd7j5dpgUu5lgQZAbhXjRESE= Date: Wed, 15 Sep 2021 15:00:40 +0200 From: Greg KH To: Yi Zhang Cc: Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, stable@vger.kernel.org Subject: Re: [bug report] nvme0n1 node still exists after blktests nvme-tcp/014 on 5.13.16-rc1 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Sep 15, 2021 at 08:41:21PM +0800, Yi Zhang wrote: > On Tue, Sep 14, 2021 at 10:28 PM Sagi Grimberg wrote: > > > > > > > Hello > > > I found this failure on stable 5.13.16-rc1[1] and cannot reproduce it > > > on 5.14, seems we are missing commit[2] on 5.13.y, could anyone help > > > check it? > > > > Was it picked up and didn't apply correctly? > > > > Hi Sagi > I tried apply that patch to stable branch, but failed to do that, > would you or Hannes mind help backport it, thanks. > > [linux-stable-rc ((daeb634aa75f...))]$ git am > 0001-nvme-fix-refcounting-imbalance-when-all-paths-are-do.patch > Applying: nvme: fix refcounting imbalance when all paths are down > error: patch failed: drivers/nvme/host/nvme.h:716 > error: drivers/nvme/host/nvme.h: patch does not apply > Patch failed at 0001 nvme: fix refcounting imbalance when all paths are down > hint: Use 'git am --show-current-patch' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > > [linux-stable-rc ((daeb634aa75f...))]$ patch -p1 < > 0001-nvme-fix-refcounting-imbalance-when-all-paths-are-do.patch > patching file drivers/nvme/host/core.c > Hunk #1 succeeded at 3761 (offset -46 lines). > Hunk #2 succeeded at 3771 (offset -46 lines). > Hunk #3 succeeded at 3790 (offset -46 lines). > patching file drivers/nvme/host/multipath.c > Hunk #1 succeeded at 757 (offset -3 lines). > patching file drivers/nvme/host/nvme.h > Hunk #1 FAILED at 716. > Hunk #2 succeeded at 775 (offset 3 lines). > 1 out of 2 hunks FAILED -- saving rejects to file drivers/nvme/host/nvme.h.rej 5.13 is only going to be around for a 2-3 more days, please move to 5.14.y at this point in time. No need to do any extra work for 5.13.y at this point in time as it is about to be end-of-life. thanks, greg k-h