ARM: 9109/1: oabi-compat: add epoll_pwait handler

ARM: 9109/1: oabi-compat: add epoll_pwait handler

[Naresh Kamboju]

Following build warnings/ errors noticed while building stable-rc 4.14...5.14
branches with gcc-8/9/10/11 for arm architecture with axm55xx_defconfig.

# to reproduce this build locally:
tuxmake --runtime podman --target-arch arm --toolchain gcc-11
--kconfig axm55xx_defconfig


build error:
------------
arch/arm/kernel/sys_oabi-compat.c:347:2: error: #endif without #if
  347 | #endif
      |  ^~~~~
make[3]: *** [scripts/Makefile.build:271:
arch/arm/kernel/sys_oabi-compat.o] Error 1

Build config:
https://builds.tuxbuild.com/1yCGjI41IKXkLhFamMRkMmNu7ak/config

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

meta data:
-----------
    git_describe: v5.14.4-74-g739800791564
    git_ref:
    git_repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc"
    git_sha: 73980079156484a4acc3b4fa06a1aaf7f7633433
    git_short_log: 739800791564 (\"Linux 5.14.5-rc1\")
    kconfig: [
        axm55xx_defconfig
    ],
    kernel_version: 5.14.5-rc1
    target_arch: arm
    toolchain: gcc-11

steps to reproduce:
https://builds.tuxbuild.com/1yCGjI41IKXkLhFamMRkMmNu7ak/tuxmake_reproducer.sh

--
Linaro LKFT
https://lkft.linaro.org

Re: ARM: 9109/1: oabi-compat: add epoll_pwait handler

[Arnd Bergmann]

On Thu, Sep 16, 2021 at 8:40 AM Naresh Kamboju
<naresh.kamboju@linaro.org> wrote:
>
> Following build warnings/ errors noticed while building stable-rc 4.14...5.14
> branches with gcc-8/9/10/11 for arm architecture with axm55xx_defconfig.
>
> # to reproduce this build locally:
> tuxmake --runtime podman --target-arch arm --toolchain gcc-11
> --kconfig axm55xx_defconfig

Thank you for the report!

This was introduced in my upstream commit b6e47f3c11c1 ("ARM: 9109/1:
oabi-compat:
add epoll_pwait handler") and fixed in the immediately following 249dbe74d3c4
("ARM: 9108/1: oabi-compat: rework epoll_wait/epoll_pwait emulation").

Only the first patch got backported to stable-rc, so it's broken
there. If anyone
thinks we want to keep the epoll_pwait emulation in stable, I can do a backport,
but I would just drop that commit from all stable kernels.

      Arnd

Re: ARM: 9109/1: oabi-compat: add epoll_pwait handler

[Greg Kroah-Hartman]

On Thu, Sep 16, 2021 at 08:57:20AM +0200, Arnd Bergmann wrote:
> On Thu, Sep 16, 2021 at 8:40 AM Naresh Kamboju
> <naresh.kamboju@linaro.org> wrote:
> >
> > Following build warnings/ errors noticed while building stable-rc 4.14...5.14
> > branches with gcc-8/9/10/11 for arm architecture with axm55xx_defconfig.
> >
> > # to reproduce this build locally:
> > tuxmake --runtime podman --target-arch arm --toolchain gcc-11
> > --kconfig axm55xx_defconfig
> 
> Thank you for the report!
> 
> This was introduced in my upstream commit b6e47f3c11c1 ("ARM: 9109/1:
> oabi-compat:
> add epoll_pwait handler") and fixed in the immediately following 249dbe74d3c4
> ("ARM: 9108/1: oabi-compat: rework epoll_wait/epoll_pwait emulation").
> 
> Only the first patch got backported to stable-rc, so it's broken
> there. If anyone
> thinks we want to keep the epoll_pwait emulation in stable, I can do a backport,
> but I would just drop that commit from all stable kernels.

Good idea, I'm going to drop it from all stable queues now.

thanks,

greg k-h