From: Sasha Levin <sashal@kernel.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: Greg KH <greg@kroah.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: cdns3: fix race condition before setting doorbell
Date: Fri, 1 Oct 2021 12:52:01 -0400 [thread overview]
Message-ID: <YVc8sZqAR1EOjrlE@sashalap> (raw)
In-Reply-To: <BYAPR07MB5381A0DD3A5CBB66D5178372DDAA9@BYAPR07MB5381.namprd07.prod.outlook.com>
On Thu, Sep 30, 2021 at 10:22:42AM +0000, Pawel Laszczak wrote:
>>
>>On Thu, Sep 30, 2021 at 11:42:17AM +0200, Pawel Laszczak wrote:
>>> From: Pawel Laszczak <pawell@cadence.com>
>>>
>>> commit b69ec50b3e55c4b2a85c8bc46763eaf33060584 upstream
>>>
>>> For DEV_VER_V3 version there exist race condition between clearing
>>> ep_sts.EP_STS_TRBERR and setting ep_cmd.EP_CMD_DRDY bit.
>>> Setting EP_CMD_DRDY will be ignored by controller when
>>> EP_STS_TRBERR is set. So, between these two instructions we have
>>> a small time gap in which the EP_STS_TRBERR can be set. In such case
>>> the transfer will not start after setting doorbell.
>>>
>>> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
>>> cc: <stable@vger.kernel.org> # 5.4.x
>>> Tested-by: Aswath Govindraju <a-govindraju@ti.com>
>>> Reviewed-by: Aswath Govindraju <a-govindraju@ti.com>
>>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>>> ---
>>> drivers/usb/cdns3/gadget.c | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>
>>What kernel(s) are you wanting this applied to?
>
>To 5.4. I added information in cc: <stable@vger.kernel.org> tag (# 5.4.x) .
>Is it sufficient or not? I ask because I need to post this fix also to v5.10.
I queued this up for both 5.10 and 5.4, thanks.
The issue seems to be that in the upstream patch you explicitly stated
to go only to 5.12:
cc: <stable@vger.kernel.org> # 5.12.x
Was that your intent?
--
Thanks,
Sasha
next prev parent reply other threads:[~2021-10-01 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 9:42 [PATCH] usb: cdns3: fix race condition before setting doorbell Pawel Laszczak
2021-09-30 10:03 ` Greg KH
2021-09-30 10:22 ` Pawel Laszczak
2021-10-01 16:52 ` Sasha Levin [this message]
2021-10-04 4:00 ` Pawel Laszczak
-- strict thread matches above, loose matches on Subject: below --
2021-09-07 6:26 Pawel Laszczak
2021-09-07 7:28 ` Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVc8sZqAR1EOjrlE@sashalap \
--to=sashal@kernel.org \
--cc=greg@kroah.com \
--cc=pawell@cadence.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox