* [PATCH 1/2] io_uring: fail iopoll links if can't retry
[not found] <cover.1634501363.git.asml.silence@gmail.com>
@ 2021-10-17 20:30 ` Pavel Begunkov
2021-10-17 20:33 ` Pavel Begunkov
2021-10-18 6:00 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Pavel Begunkov @ 2021-10-17 20:30 UTC (permalink / raw)
To: asml.silence; +Cc: stable
If io_rw_should_reissue() fails in iopoll path and we can't reissue we
fail the request. Don't forget to also mark it as failed, so links are
broken.
Cc: stable@vger.kernel.org
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
fs/io_uring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 0d7613c7355c..40b1697e7354 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2687,6 +2687,7 @@ static void io_complete_rw_iopoll(struct kiocb *kiocb, long res, long res2)
req->flags |= REQ_F_REISSUE;
return;
}
+ req_set_fail(req);
req->result = res;
}
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/2] io_uring: fail iopoll links if can't retry
2021-10-17 20:30 ` [PATCH 1/2] io_uring: fail iopoll links if can't retry Pavel Begunkov
@ 2021-10-17 20:33 ` Pavel Begunkov
2021-10-18 6:00 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Begunkov @ 2021-10-17 20:33 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, Pavel Begunkov, stable
If io_rw_should_reissue() fails in iopoll path and we can't reissue we
fail the request. Don't forget to also mark it as failed, so links are
broken.
Cc: stable@vger.kernel.org
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
fs/io_uring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 0d7613c7355c..40b1697e7354 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2687,6 +2687,7 @@ static void io_complete_rw_iopoll(struct kiocb *kiocb, long res, long res2)
req->flags |= REQ_F_REISSUE;
return;
}
+ req_set_fail(req);
req->result = res;
}
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] io_uring: fail iopoll links if can't retry
2021-10-17 20:30 ` [PATCH 1/2] io_uring: fail iopoll links if can't retry Pavel Begunkov
2021-10-17 20:33 ` Pavel Begunkov
@ 2021-10-18 6:00 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-10-18 6:00 UTC (permalink / raw)
To: Pavel Begunkov; +Cc: stable
On Sun, Oct 17, 2021 at 08:30:55PM +0000, Pavel Begunkov wrote:
> If io_rw_should_reissue() fails in iopoll path and we can't reissue we
> fail the request. Don't forget to also mark it as failed, so links are
> broken.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> fs/io_uring.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 0d7613c7355c..40b1697e7354 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -2687,6 +2687,7 @@ static void io_complete_rw_iopoll(struct kiocb *kiocb, long res, long res2)
> req->flags |= REQ_F_REISSUE;
> return;
> }
> + req_set_fail(req);
> req->result = res;
> }
>
> --
> 2.33.1
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-18 6:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1634501363.git.asml.silence@gmail.com>
2021-10-17 20:30 ` [PATCH 1/2] io_uring: fail iopoll links if can't retry Pavel Begunkov
2021-10-17 20:33 ` Pavel Begunkov
2021-10-18 6:00 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).