From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 534FCC433F5 for ; Mon, 18 Oct 2021 10:27:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EDAD60FF2 for ; Mon, 18 Oct 2021 10:27:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbhJRKaB (ORCPT ); Mon, 18 Oct 2021 06:30:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:59618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbhJRKaA (ORCPT ); Mon, 18 Oct 2021 06:30:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4FC0A6103B; Mon, 18 Oct 2021 10:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634552869; bh=vR8sZyVkRbpHfpVst3LFjv0sEWuHUIkw5sWdntckSH8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OlxbHK6nv+POxLRZif5KCZ2KLJtqYffj4Fa38V8HEjbZW+R1Qg3aq9fUEDTEHxtRN NVeH8DQ9AH33DgQoyp44GneEYDiNZA61FBAmV3ny/8LvThXK/MyHAwCXWNEZTttuM0 3t22WIogTV8eO/zo83OYoK//zGCvTEL9BVVHCtYE= Date: Mon, 18 Oct 2021 12:27:47 +0200 From: Greg KH To: "Michael S. Tsirkin" Cc: ckulkarnilinux@gmail.com, hch@lst.de, mgurtovoy@nvidia.com, stefanha@redhat.com, stable-commits@vger.kernel.org, stable@vger.kernel.org Subject: Re: Patch "virtio-blk: remove unneeded "likely" statements" has been added to the 5.14-stable tree Message-ID: References: <163455135025212@kroah.com> <20211018062109-mutt-send-email-mst@kernel.org> <20211018062237-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018062237-mutt-send-email-mst@kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Oct 18, 2021 at 06:23:11AM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 18, 2021 at 06:22:13AM -0400, Michael S. Tsirkin wrote: > > On Mon, Oct 18, 2021 at 12:02:30PM +0200, gregkh@linuxfoundation.org wrote: > > > > > > This is a note to let you know that I've just added the patch titled > > > > > > virtio-blk: remove unneeded "likely" statements > > > > > > to the 5.14-stable tree which can be found at: > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > The filename of the patch is: > > > virtio-blk-remove-unneeded-likely-statements.patch > > > and it can be found in the queue-5.14 subdirectory. > > > > > > If you, or anyone else, feels it should not be added to the stable tree, > > > please let know about it. > > > > > > > > > >From 6105d1fe6f4c24ce8c13e2e6568b16b76e04983d Mon Sep 17 00:00:00 2001 > > > From: Max Gurtovoy > > > Date: Sun, 5 Sep 2021 11:57:17 +0300 > > > Subject: virtio-blk: remove unneeded "likely" statements > > > > > > From: Max Gurtovoy > > > > > > commit 6105d1fe6f4c24ce8c13e2e6568b16b76e04983d upstream. > > > > > > Usually we use "likely/unlikely" to optimize the fast path. Remove > > > redundant "likely/unlikely" statements in the control path to simplify > > > the code and make it easier to read. > > > > > > Reviewed-by: Stefan Hajnoczi > > > Signed-off-by: Max Gurtovoy > > > Link: https://lore.kernel.org/r/20210905085717.7427-1-mgurtovoy@nvidia.com > > > Signed-off-by: Michael S. Tsirkin > > > Reviewed-by: Chaitanya Kulkarni > > > Reviewed-by: Christoph Hellwig > > > Reviewed-by: Stefan Hajnoczi > > > Signed-off-by: Greg Kroah-Hartman > > > > It's harmless but doesn't seem appropriate for stable. > > Oh, I guess it's been picked because the next patch that > was picked depends on it. OK then, sorry about the noise. Yeah, that's why I grabbed it :) thanks, greg k-h