From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Will Deacon <will@kernel.org>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Simon Trimmer <simont@opensource.cirrus.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linux@armlinux.org.uk, catalin.marinas@arm.com,
tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com,
deller@gmx.de, paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, linus.walleij@linaro.org,
geert+renesas@glider.be, rmk+kernel@armlinux.org.uk,
akpm@linux-foundation.org, anshuman.khandual@arm.com,
mark.rutland@arm.com, ardb@kernel.org,
u.kleine-koenig@pengutronix.de, rppt@kernel.org,
lukas.bulwahn@gmail.com, wangkefeng.wang@huawei.com,
slyfox@gentoo.org, axboe@kernel.dk, ben.widawsky@intel.com,
dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org,
linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally
Date: Wed, 13 Oct 2021 07:58:58 +0200 [thread overview]
Message-ID: <YWZ1om+pLmV3atTd@kroah.com> (raw)
In-Reply-To: <20211013005532.700190-11-sashal@kernel.org>
On Tue, Oct 12, 2021 at 08:55:31PM -0400, Sasha Levin wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> [ Upstream commit 951cd3a0866d29cb9c01ebc1d9c17590e598226e ]
>
> Compile-testing drivers that require access to a firmware layer
> fails when that firmware symbol is unavailable. This happened
> twice this week:
>
> - My proposed to change to rework the QCOM_SCM firmware symbol
> broke on ppc64 and others.
>
> - The cs_dsp firmware patch added device specific firmware loader
> into drivers/firmware, which broke on the same set of
> architectures.
>
> We should probably do the same thing for other subsystems as well,
> but fix this one first as this is a dependency for other patches
> getting merged.
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Acked-by: Will Deacon <will@kernel.org>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Charles Keepax <ckeepax@opensource.cirrus.com>
> Cc: Simon Trimmer <simont@opensource.cirrus.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Reviewed-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> arch/arm/Kconfig | 2 --
> arch/arm64/Kconfig | 2 --
> arch/ia64/Kconfig | 2 --
> arch/mips/Kconfig | 2 --
> arch/parisc/Kconfig | 2 --
> arch/riscv/Kconfig | 2 --
> arch/x86/Kconfig | 2 --
> drivers/Kconfig | 2 ++
> 8 files changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 002e0cf025f5..d4c6b95b24d7 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -2043,8 +2043,6 @@ config ARCH_HIBERNATION_POSSIBLE
>
> endmenu
>
> -source "drivers/firmware/Kconfig"
> -
> if CRYPTO
> source "arch/arm/crypto/Kconfig"
> endif
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 5e5cf3af6351..f4809760a806 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1933,8 +1933,6 @@ source "drivers/cpufreq/Kconfig"
>
> endmenu
>
> -source "drivers/firmware/Kconfig"
> -
> source "drivers/acpi/Kconfig"
>
> source "arch/arm64/kvm/Kconfig"
> diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
> index 39b25a5a591b..e8014d2e36c0 100644
> --- a/arch/ia64/Kconfig
> +++ b/arch/ia64/Kconfig
> @@ -426,8 +426,6 @@ config CRASH_DUMP
> help
> Generate crash dump after being started by kexec.
>
> -source "drivers/firmware/Kconfig"
> -
> endmenu
>
> menu "Power management and ACPI options"
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 1a63f592034e..3bd3a01a2a2b 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -3328,8 +3328,6 @@ source "drivers/cpuidle/Kconfig"
>
> endmenu
>
> -source "drivers/firmware/Kconfig"
> -
> source "arch/mips/kvm/Kconfig"
>
> source "arch/mips/vdso/Kconfig"
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index 14f3252f2da0..ad13477fb40c 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -378,6 +378,4 @@ config KEXEC_FILE
>
> endmenu
>
> -source "drivers/firmware/Kconfig"
> -
> source "drivers/parisc/Kconfig"
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index f7abd118d23d..fcb8e5da148e 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -428,5 +428,3 @@ menu "Power management options"
> source "kernel/power/Kconfig"
>
> endmenu
> -
> -source "drivers/firmware/Kconfig"
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index f3c8a8110f60..499f3cc1e62f 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2899,8 +2899,6 @@ config HAVE_ATOMIC_IOMAP
> def_bool y
> depends on X86_32
>
> -source "drivers/firmware/Kconfig"
> -
> source "arch/x86/kvm/Kconfig"
>
> source "arch/x86/Kconfig.assembler"
> diff --git a/drivers/Kconfig b/drivers/Kconfig
> index dcecc9f6e33f..493ac7ffd8d0 100644
> --- a/drivers/Kconfig
> +++ b/drivers/Kconfig
> @@ -16,6 +16,8 @@ source "drivers/bus/Kconfig"
>
> source "drivers/connector/Kconfig"
>
> +source "drivers/firmware/Kconfig"
> +
> source "drivers/gnss/Kconfig"
>
> source "drivers/mtd/Kconfig"
> --
> 2.33.0
>
This isn't for stable kernels, it should be dropped from all of your
AUTOSEL queues.
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-13 5:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 0:55 [PATCH AUTOSEL 5.10 01/11] arm: dts: vexpress-v2p-ca9: Fix the SMB unit-address Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 02/11] ARM: config: mutli v7: Reenable FB dependency Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 03/11] ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 04/11] block: decode QUEUE_FLAG_HCTX_ACTIVE in debugfs output Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 05/11] xen/x86: prevent PVH type from getting clobbered Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 06/11] drm/amdgpu/display: fix dependencies for DRM_AMD_DC_SI Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 07/11] xtensa: xtfpga: use CONFIG_USE_OF instead of CONFIG_OF Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 08/11] xtensa: xtfpga: Try software restart before simulating CPU reset Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 09/11] NFSD: Keep existing listeners on portlist error Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 10/11] powerpc/security: Add a helper to query stf_barrier type Sasha Levin
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally Sasha Levin
2021-10-13 5:58 ` Greg KH [this message]
2021-10-13 8:38 ` Arnd Bergmann
2021-10-13 8:45 ` Uwe Kleine-König
2021-10-13 8:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWZ1om+pLmV3atTd@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=ben.widawsky@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=dan.j.williams@intel.com \
--cc=deller@gmx.de \
--cc=geert+renesas@glider.be \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lukas.bulwahn@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=sashal@kernel.org \
--cc=simont@opensource.cirrus.com \
--cc=slyfox@gentoo.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox