public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usbnet: sanity check for maxpacket
@ 2021-10-26  2:20 Tadeusz Struk
  2021-10-26  5:43 ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Tadeusz Struk @ 2021-10-26  2:20 UTC (permalink / raw)
  To: stable; +Cc: Oliver Neukum, Jakub Kicinski, tadeusz.struk


[-- Attachment #1.1: Type: text/plain, Size: 356 bytes --]

Hi,
Upstream commit id: 397430b50a363d8b7bdda00522123f82df6adc5e
should be applied because it fixes an Oops (divide by zero) that can be
triggered from user space. See:
https://syzkaller.appspot.com/bug?id=2ebf7e5eb303ac9a598e0dab2c0c8b03ead7abce

It should be applied to stable kernels: 5.14, 5.10, 5.4, 4.19, 4.14, 4.9, 4.4
-- 
Thanks,
Tadeusz

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] usbnet: sanity check for maxpacket
  2021-10-26  2:20 [PATCH] usbnet: sanity check for maxpacket Tadeusz Struk
@ 2021-10-26  5:43 ` Greg KH
  2021-10-26 14:52   ` Tadeusz Struk
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2021-10-26  5:43 UTC (permalink / raw)
  To: Tadeusz Struk; +Cc: stable, Oliver Neukum, Jakub Kicinski

On Mon, Oct 25, 2021 at 07:20:31PM -0700, Tadeusz Struk wrote:
> Hi,
> Upstream commit id: 397430b50a363d8b7bdda00522123f82df6adc5e
> should be applied because it fixes an Oops (divide by zero) that can be
> triggered from user space. See:
> https://syzkaller.appspot.com/bug?id=2ebf7e5eb303ac9a598e0dab2c0c8b03ead7abce
> 
> It should be applied to stable kernels: 5.14, 5.10, 5.4, 4.19, 4.14, 4.9, 4.4

It's already in the latest stable -rc releases, do you not see it there?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] usbnet: sanity check for maxpacket
  2021-10-26  5:43 ` Greg KH
@ 2021-10-26 14:52   ` Tadeusz Struk
  2021-10-26 15:03     ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Tadeusz Struk @ 2021-10-26 14:52 UTC (permalink / raw)
  To: Greg KH; +Cc: stable, Oliver Neukum, Jakub Kicinski

On 10/25/21 22:43, Greg KH wrote:
>> It should be applied to stable kernels: 5.14, 5.10, 5.4, 4.19, 4.14, 4.9, 4.4
> It's already in the latest stable -rc releases, do you not see it there?

I haven't checked the rc releases, just the latest stable versions.
Now I also see Sasha Levin's submissions on the stable mailing list archive.
All good. Sorry for the noise.

-- 
Thanks,
Tadeusz

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] usbnet: sanity check for maxpacket
  2021-10-26 14:52   ` Tadeusz Struk
@ 2021-10-26 15:03     ` Greg KH
  2021-10-26 15:08       ` Tadeusz Struk
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2021-10-26 15:03 UTC (permalink / raw)
  To: Tadeusz Struk; +Cc: stable, Oliver Neukum, Jakub Kicinski

On Tue, Oct 26, 2021 at 07:52:00AM -0700, Tadeusz Struk wrote:
> On 10/25/21 22:43, Greg KH wrote:
> > > It should be applied to stable kernels: 5.14, 5.10, 5.4, 4.19, 4.14, 4.9, 4.4
> > It's already in the latest stable -rc releases, do you not see it there?
> 
> I haven't checked the rc releases, just the latest stable versions.
> Now I also see Sasha Levin's submissions on the stable mailing list archive.
> All good. Sorry for the noise.

Also note that there is a bug in this commit, so it was dropped from the
stable queues until the fix for this hits Linus's tree.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] usbnet: sanity check for maxpacket
  2021-10-26 15:03     ` Greg KH
@ 2021-10-26 15:08       ` Tadeusz Struk
  2021-10-26 15:19         ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Tadeusz Struk @ 2021-10-26 15:08 UTC (permalink / raw)
  To: Greg KH; +Cc: stable, Oliver Neukum, Jakub Kicinski


[-- Attachment #1.1: Type: text/plain, Size: 744 bytes --]

On 10/26/21 08:03, Greg KH wrote:
> On Tue, Oct 26, 2021 at 07:52:00AM -0700, Tadeusz Struk wrote:
>> On 10/25/21 22:43, Greg KH wrote:
>>>> It should be applied to stable kernels: 5.14, 5.10, 5.4, 4.19, 4.14, 4.9, 4.4
>>> It's already in the latest stable -rc releases, do you not see it there?
>>
>> I haven't checked the rc releases, just the latest stable versions.
>> Now I also see Sasha Levin's submissions on the stable mailing list archive.
>> All good. Sorry for the noise.
> 
> Also note that there is a bug in this commit, so it was dropped from the
> stable queues until the fix for this hits Linus's tree.
> 

Good to know. Ideally we could also add some netif_warn() message for the user.

-- 
Thanks,
Tadeusz

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] usbnet: sanity check for maxpacket
  2021-10-26 15:08       ` Tadeusz Struk
@ 2021-10-26 15:19         ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-10-26 15:19 UTC (permalink / raw)
  To: Tadeusz Struk; +Cc: stable, Oliver Neukum, Jakub Kicinski

On Tue, Oct 26, 2021 at 08:08:37AM -0700, Tadeusz Struk wrote:
> On 10/26/21 08:03, Greg KH wrote:
> > On Tue, Oct 26, 2021 at 07:52:00AM -0700, Tadeusz Struk wrote:
> > > On 10/25/21 22:43, Greg KH wrote:
> > > > > It should be applied to stable kernels: 5.14, 5.10, 5.4, 4.19, 4.14, 4.9, 4.4
> > > > It's already in the latest stable -rc releases, do you not see it there?
> > > 
> > > I haven't checked the rc releases, just the latest stable versions.
> > > Now I also see Sasha Levin's submissions on the stable mailing list archive.
> > > All good. Sorry for the noise.
> > 
> > Also note that there is a bug in this commit, so it was dropped from the
> > stable queues until the fix for this hits Linus's tree.
> > 
> 
> Good to know. Ideally we could also add some netif_warn() message for the user.

Why?  It's an "obviously broken" device that is created just to try to
harm the kernel.  No need to be noisy about it.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-26 15:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26  2:20 [PATCH] usbnet: sanity check for maxpacket Tadeusz Struk
2021-10-26  5:43 ` Greg KH
2021-10-26 14:52   ` Tadeusz Struk
2021-10-26 15:03     ` Greg KH
2021-10-26 15:08       ` Tadeusz Struk
2021-10-26 15:19         ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox