From: Greg KH <gregkh@linuxfoundation.org>
To: Erik Ekman <erik@kryo.se>
Cc: stable@vger.kernel.org
Subject: Re: sfc: Fix reading non-legacy supported link modes
Date: Wed, 3 Nov 2021 10:41:06 +0100 [thread overview]
Message-ID: <YYJZMuOFNQiJ3rGC@kroah.com> (raw)
In-Reply-To: <CAGgu=sBsiSVgr=uR95ZXFTtziLUO_LS4CW+6n2p2iBWxf2aq6A@mail.gmail.com>
On Tue, Nov 02, 2021 at 09:58:22PM +0100, Erik Ekman wrote:
> Upstream commit 041c61488236a5a84789083e3d9f0a51139b6edf
>
> Initially this just fixed 50G and 100G modes which felt rare enough to
> not apply this to stable (also it got merged before I really had
> thought about it).
>
> The testing mentioned in the change was actually from my development
> of c62041c5ba ("sfc: Export fibre-specific supported link modes"). I
> failed to mention the link between the two changes however and this
> commit ended up in net-next (just merged) while the second ended up in
> 5.15 via the net branch. The result is that for 5.15 even 10G cards
> only show 1G as supported:
>
> $ ethtool ext
> Settings for ext:
> Supported ports: [ FIBRE ]
> Supported link modes: 1000baseT/Full
> Supported pause frame use: Symmetric Receive-only
> [..]
>
> So this commit is needed at least for 5.15 to fix that.
>
> Fixes: c62041c5ba ("sfc: Export fibre-specific supported link modes")
>
> It can also be applied further back if we want to fix the 50/100G
> modes (from v4.16 I believe):
>
> Fixes: 5abb5e7f916 ("sfc: add bits for 25/50/100G supported/advertised speeds")
I have queued this up for 5.10.y, 5.14.y, and 5.15.y now, but I need a
backported version for 5.4.y and 4.19.y please.
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-03 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 20:58 sfc: Fix reading non-legacy supported link modes Erik Ekman
2021-11-03 9:41 ` Greg KH [this message]
2021-11-03 11:34 ` Erik Ekman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYJZMuOFNQiJ3rGC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=erik@kryo.se \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox