From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 5.10] scripts/lld-version.sh: Rewrite based on upstream ld-version.sh
Date: Fri, 19 Nov 2021 15:28:39 +0100 [thread overview]
Message-ID: <YZe0lxrHLICffsUC@kroah.com> (raw)
In-Reply-To: <CAKwvOdnXGSkh4VM9Frn_OHMvdMpaXAH9dVsap34mKv7PcurrZQ@mail.gmail.com>
On Mon, Nov 15, 2021 at 09:50:01AM -0800, Nick Desaulniers wrote:
> On Mon, Nov 15, 2021 at 8:46 AM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > This patch is for linux-5.10.y only.
> >
> > When scripts/lld-version.sh was initially written, it did not account
> > for the LLD_VENDOR cmake flag, which changes the output of ld.lld's
> > --version flag slightly.
> >
> > Without LLD_VENDOR:
> >
> > $ ld.lld --version
> > LLD 14.0.0 (compatible with GNU linkers)
> >
> > With LLD_VENDOR:
> >
> > $ ld.lld --version
> > Debian LLD 14.0.0 (compatible with GNU linkers)
> >
> > As a result, CONFIG_LLD_VERSION is messed up and configuration values
> > that are dependent on it cannot be selected:
> >
> > scripts/lld-version.sh: 20: printf: LLD: expected numeric value
> > scripts/lld-version.sh: 20: printf: LLD: expected numeric value
> > scripts/lld-version.sh: 20: printf: LLD: expected numeric value
> > init/Kconfig:52:warning: 'LLD_VERSION': number is invalid
> > .config:11:warning: symbol value '00000' invalid for LLD_VERSION
> > .config:8800:warning: override: CPU_BIG_ENDIAN changes choice state
> >
> > This was fixed upstream by commit 1f09af062556 ("kbuild: Fix
> > ld-version.sh script if LLD was built with LLD_VENDOR") in 5.12 but that
> > was done to ld-version.sh after it was massively rewritten in
> > commit 02aff8592204 ("kbuild: check the minimum linker version in
> > Kconfig").
> >
> > To avoid bringing in that change plus its prerequisites and fixes, just
> > modify lld-version.sh to make it similar to the upstream ld-version.sh,
> > which handles ld.lld with or without LLD_VENDOR and ld.bfd without any
> > errors.
> >
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Thanks for the fix.
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2021-11-19 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 16:43 [PATCH 5.10] scripts/lld-version.sh: Rewrite based on upstream ld-version.sh Nathan Chancellor
2021-11-15 17:50 ` Nick Desaulniers
2021-11-19 14:28 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZe0lxrHLICffsUC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox