public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>,
	stable@vger.kernel.org, mw@semihalf.com,
	linux-arm-kernel@lists.infradead.org, stefanc@marvell.com
Subject: Re: ClearFog GT 8K not initialising SFP-H10GB-CU1M transceiver on 5.4.150
Date: Tue, 23 Nov 2021 13:20:06 +0100	[thread overview]
Message-ID: <YZzcdgvlznKJ1nYr@kroah.com> (raw)
In-Reply-To: <YZv1SBrYTXmorcLJ@shell.armlinux.org.uk>

On Mon, Nov 22, 2021 at 07:53:44PM +0000, Russell King (Oracle) wrote:
> On Mon, Nov 22, 2021 at 02:51:36PM +0400, Jordan Vrtanoski wrote:
> > Hi,
> >     After bisecting, the regression defect was introduced in 5.4.90 with the following patch:
> > "[PATCH net v3] net: mvpp2: disable force link UP during port init procedure”
> > 
> >     The patch is changing the configuration of the port during the initialisation of MVPP22_XLG_CTRL0_REG, which
> > on ClearFog GT 8K is preventing the MVPP2 to properly start the MAC after the transceiver is detected. After reverting 
> > the patch, the transceiver works properly.
> 
> Right, the problem will be 875082244853 ("net: mvpp2: disable force
> link UP during port init procedure") that has been backported to
> kernels that it shouldn't have been applied to.
> 
> There is a subtle interaction between that commit and development work
> leading up to it that wasn't obvious during the review. Specifically,
> any kernel without fefeae73ac7a ("net: mvpp2: ensure the port is forced
> down while changing modes") will now be broken.
> 
> However, fefeae73ac7a is development work, and so can't be backported.
> 
> Adding stable to this thread so they're aware of the issue.

I've now reverted the commit in the 5.4.y tree.

thanks,

greg k-h

      reply	other threads:[~2021-11-23 12:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3AB36F18-250C-46F5-8135-94C79102B8A5@gmail.com>
     [not found] ` <YZONJC7KhACsq+5m@shell.armlinux.org.uk>
     [not found]   ` <A2513E97-0C96-4E16-A9D2-98BB90490229@gmail.com>
     [not found]     ` <YZlPeoRLSJKNJZ5F@shell.armlinux.org.uk>
     [not found]       ` <256509AE-EE75-40AF-882F-F84A55F98C2D@gmail.com>
     [not found]         ` <2F6C75BF-6CD8-4A58-B8AA-4D3A6B5A1008@gmail.com>
2021-11-22 19:53           ` ClearFog GT 8K not initialising SFP-H10GB-CU1M transceiver on 5.4.150 Russell King (Oracle)
2021-11-23 12:20             ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZzcdgvlznKJ1nYr@kroah.com \
    --to=greg@kroah.com \
    --cc=jordan.vrtanoski@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=stable@vger.kernel.org \
    --cc=stefanc@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox