From: Greg KH <gregkh@linuxfoundation.org>
To: Luca Coelho <luca@coelho.fi>
Cc: stable@vger.kernel.org, kvalo@codeaurora.org,
mordechay.goodstein@intel.com
Subject: Re: [PATCH 5.10] iwlwifi: mvm: retry init flow if failed
Date: Mon, 6 Dec 2021 09:50:15 +0100 [thread overview]
Message-ID: <Ya3Oxz+d8OuCUsIO@kroah.com> (raw)
In-Reply-To: <20211204110202.837370-1-luca@coelho.fi>
On Sat, Dec 04, 2021 at 01:02:02PM +0200, Luca Coelho wrote:
> From: Mordechay Goodstein <mordechay.goodstein@intel.com>
>
> commit 5283dd677e52af9db6fe6ad11b2f12220d519d0c upstream.
>
> In some very rare cases the init flow may fail. In many cases, this is
> recoverable, so we can retry. Implement a loop to retry two more times
> after the first attempt failed.
>
> This can happen in two different situations, namely during probe and
> during mac80211 start. For the first case, a simple loop is enough.
> For the second case, we need to add a flag to prevent mac80211 from
> trying to restart it as well, leaving full control with the driver.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> Link: https://lore.kernel.org/r/iwlwifi.20211110150132.57514296ecab.I52a0411774b700bdc7dedb124d8b59bf99456eb2@changeid
> ---
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 22 +++++++++++------
> drivers/net/wireless/intel/iwlwifi/iwl-drv.h | 3 +++
> .../net/wireless/intel/iwlwifi/mvm/mac80211.c | 24 ++++++++++++++++++-
> drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 3 +++
> drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 3 +++
> 5 files changed, 47 insertions(+), 8 deletions(-)
Both backports now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2021-12-06 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 10:30 FAILED: patch "[PATCH] iwlwifi: mvm: retry init flow if failed" failed to apply to 5.4-stable tree gregkh
2021-12-04 11:02 ` [PATCH 5.10] iwlwifi: mvm: retry init flow if failed Luca Coelho
2021-12-06 8:50 ` Greg KH [this message]
2021-12-04 11:05 ` [PATCH 5.4] " Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya3Oxz+d8OuCUsIO@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=luca@coelho.fi \
--cc=mordechay.goodstein@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox