From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: stable@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] xtensa: use CONFIG_USE_OF instead of CONFIG_OF
Date: Mon, 29 Nov 2021 14:14:40 +0100 [thread overview]
Message-ID: <YaTSQJ6DQLhOCLic@kroah.com> (raw)
In-Reply-To: <20211129130626.25163-1-jcmvbkbc@gmail.com>
On Mon, Nov 29, 2021 at 05:06:26AM -0800, Max Filippov wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> commit d67ed2510d28a1eb33171010d35cf52178cfcbdd upstream.
>
> CONFIG_OF can be set by a randconfig or by a user -- without setting the
> early flattree option (OF_EARLY_FLATTREE). This causes build errors.
> However, if randconfig or a user sets USE_OF in the Xtensa config,
> the right kconfig symbols are set to fix the build.
>
> Fixes these build errors:
>
> ../arch/xtensa/kernel/setup.c:67:19: error: ‘__dtb_start’ undeclared here (not in a function); did you mean ‘dtb_start’?
> 67 | void *dtb_start = __dtb_start;
> | ^~~~~~~~~~~
> ../arch/xtensa/kernel/setup.c: In function 'xtensa_dt_io_area':
> ../arch/xtensa/kernel/setup.c:201:14: error: implicit declaration of function 'of_flat_dt_is_compatible'; did you mean 'of_machine_is_compatible'? [-Werror=implicit-function-declaration]
> 201 | if (!of_flat_dt_is_compatible(node, "simple-bus"))
> ../arch/xtensa/kernel/setup.c:204:18: error: implicit declaration of function 'of_get_flat_dt_prop' [-Werror=implicit-function-declaration]
> 204 | ranges = of_get_flat_dt_prop(node, "ranges", &len);
> ../arch/xtensa/kernel/setup.c:204:16: error: assignment to 'const __be32 *' {aka 'const unsigned int *'} from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> 204 | ranges = of_get_flat_dt_prop(node, "ranges", &len);
> | ^
> ../arch/xtensa/kernel/setup.c: In function 'early_init_devtree':
> ../arch/xtensa/kernel/setup.c:228:9: error: implicit declaration of function 'early_init_dt_scan'; did you mean 'early_init_devtree'? [-Werror=implicit-function-declaration]
> 228 | early_init_dt_scan(params);
> ../arch/xtensa/kernel/setup.c:229:9: error: implicit declaration of function 'of_scan_flat_dt' [-Werror=implicit-function-declaration]
> 229 | of_scan_flat_dt(xtensa_dt_io_area, NULL);
>
> xtensa-elf-ld: arch/xtensa/mm/mmu.o:(.text+0x0): undefined reference to `xtensa_kio_paddr'
>
> Fixes: da844a81779e ("xtensa: add device trees support")
> Fixes: 6cb971114f63 ("xtensa: remap io area defined in device tree")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> arch/xtensa/include/asm/vectors.h | 2 +-
> arch/xtensa/kernel/setup.c | 12 ++++++------
> arch/xtensa/mm/mmu.c | 2 +-
> 3 files changed, 8 insertions(+), 8 deletions(-)
Thanks, now updated.
greg k-h
prev parent reply other threads:[~2021-11-29 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 13:06 [PATCH] xtensa: use CONFIG_USE_OF instead of CONFIG_OF Max Filippov
2021-11-29 13:14 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaTSQJ6DQLhOCLic@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=rdunlap@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).