From: Greg KH <greg@kroah.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: stable@vger.kernel.org, Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH] can: pch_can: pch_can_rx_normal: fix use after free
Date: Sun, 12 Dec 2021 14:19:22 +0100 [thread overview]
Message-ID: <YbX22nbGbYFWKele@kroah.com> (raw)
In-Reply-To: <20211211212306.797338-1-mkl@pengutronix.de>
On Sat, Dec 11, 2021 at 10:23:06PM +0100, Marc Kleine-Budde wrote:
> From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>
> commit 94cddf1e9227a171b27292509d59691819c458db upstream.
>
> After calling netif_receive_skb(skb), dereferencing skb is unsafe.
> Especially, the can_frame cf which aliases skb memory is dereferenced
> just after the call netif_receive_skb(skb).
>
> Reordering the lines solves the issue.
>
> Fixes: b21d18b51b31 ("can: Topcliff: Add PCH_CAN driver.")
> Link: https://lore.kernel.org/all/20211123111654.621610-1-mailhol.vincent@wanadoo.fr
> Cc: stable@vger.kernel.org
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> [mkl: backport to v5.10]
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> Hey Greg,
>
> this is the backport of
> | 94cddf1e9227 ("can: pch_can: pch_can_rx_normal: fix use after free")
> to v5.10
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2021-12-12 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-11 21:23 [PATCH] can: pch_can: pch_can_rx_normal: fix use after free Marc Kleine-Budde
2021-12-12 13:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbX22nbGbYFWKele@kroah.com \
--to=greg@kroah.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox