From: Greg KH <gregkh@linuxfoundation.org>
To: Armin Wolf <W_Armin@gmx.de>
Cc: pali@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Fix warning on /proc/i8k creation error
Date: Wed, 15 Dec 2021 14:54:41 +0100 [thread overview]
Message-ID: <YbnzoesmSK4ETHho@kroah.com> (raw)
In-Reply-To: <20211214210047.33489-1-W_Armin@gmx.de>
On Tue, Dec 14, 2021 at 10:00:47PM +0100, Armin Wolf wrote:
> commit dbd3e6eaf3d813939b28e8a66e29d81cdc836445 upstream.
>
> The removal function is called regardless of whether
> /proc/i8k was created successfully or not, the later
> causing a WARN() on module removal.
> Fix that by only calling the removal function
> if /proc/i8k was created successfully.
>
> Since the original patch depends on the driver
> registering a platform device, the backported patch
> stores the return value of proc_create() and only
> calls proc_remove_entry() on exit if proc_create()
> was successful.
>
> Tested on a Inspiron 3505 for kernel 5.10.
>
> Cc: <stable@vger.kernel.org> # 5.10.x
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
All now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2021-12-15 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 21:00 [PATCH] hwmon: (dell-smm) Fix warning on /proc/i8k creation error Armin Wolf
2021-12-15 13:54 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-14 21:06 Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbnzoesmSK4ETHho@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=W_Armin@gmx.de \
--cc=pali@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox