From: Greg KH <gregkh@linuxfoundation.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>,
idryomov@gmail.com, stable@vger.kernel.org,
Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH v5.10] ceph: fix up non-directory creation in SGID directories
Date: Thu, 23 Dec 2021 11:20:07 +0100 [thread overview]
Message-ID: <YcRNV5z5bkSNu2kr@kroah.com> (raw)
In-Reply-To: <20211223095733.587981-1-brauner@kernel.org>
On Thu, Dec 23, 2021 at 10:57:33AM +0100, Christian Brauner wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
>
> Ceph always inherits the SGID bit if it is set on the parent inode,
> while the generic inode_init_owner does not do this in a few cases where
> it can create a possible security problem (cf. [1]).
>
> Update ceph to strip the SGID bit just as inode_init_owner would.
>
> This bug was detected by the mapped mount testsuite in [3]. The
> testsuite tests all core VFS functionality and semantics with and
> without mapped mounts. That is to say it functions as a generic VFS
> testsuite in addition to a mapped mount testsuite. While working on
> mapped mount support for ceph, SIGD inheritance was the only failing
> test for ceph after the port.
>
> The same bug was detected by the mapped mount testsuite in XFS in
> January 2021 (cf. [2]).
>
> [1]: commit 0fa3ecd87848 ("Fix up non-directory creation in SGID directories")
> [2]: commit 01ea173e103e ("xfs: fix up non-directory creation in SGID directories")
> [3]: https://git.kernel.org/fs/xfs/xfstests-dev.git
>
> Cc: stable@vger.kernel.org (adapted to v5.10)
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
> ---
> fs/ceph/file.c | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
What is the git commit id in Linus's tree?
next prev parent reply other threads:[~2021-12-23 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <https://lore.kernel.org/stable/YcBgWdVOT6GtICE6@kroah.com>
2021-12-23 9:57 ` [PATCH v5.10] ceph: fix up non-directory creation in SGID directories Christian Brauner
2021-12-23 10:20 ` Greg KH [this message]
2021-12-23 10:31 ` Christian Brauner
2021-12-27 12:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcRNV5z5bkSNu2kr@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=brauner@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox