stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	tglx@linutronix.de, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] rtc: mc146818-lib: fix RTC presence check" failed to apply to 5.16-stable tree
Date: Mon, 24 Jan 2022 15:52:44 +0100	[thread overview]
Message-ID: <Ye69PKB2V/R/NxN8@kroah.com> (raw)
In-Reply-To: <df1a2547-c863-f416-58c9-4f64cce1f522@o2.pl>

On Mon, Jan 24, 2022 at 03:45:30PM +0100, Mateusz Jończyk wrote:
> W dniu 24.01.2022 o 14:08, gregkh@linuxfoundation.org pisze:
> > The patch below does not apply to the 5.16-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
> > thanks,
> >
> > greg k-h
> Wait, this patch was not intended for submission into stable yet, at least not in this form.
> Why did it end up in the stable queue?

Because it was marked with a "Fixes:" tag and I reviewed it and it
looked like it actually fixed an issue.

Is this not the case?

> The return values from mc146818_get_time() changed in between,
> so it is natural that it does not apply.
> 
> See
> commit d35786b3a28dee20 ("rtc: mc146818-lib: change return values of mc146818_get_time()")

Ok, so will a working backport be sent sometime in the future?

thanks,

greg k-h

  reply	other threads:[~2022-01-24 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 13:08 FAILED: patch "[PATCH] rtc: mc146818-lib: fix RTC presence check" failed to apply to 5.16-stable tree gregkh
2022-01-24 14:45 ` Mateusz Jończyk
2022-01-24 14:52   ` Greg KH [this message]
2022-01-24 16:27     ` Mateusz Jończyk
2022-01-26 13:56       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ye69PKB2V/R/NxN8@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=mat.jonczyk@o2.pl \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).