From: Greg KH <gregkh@linuxfoundation.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: stable@vger.kernel.org, Alexander.Deucher@amd.com,
harry.wentland@amd.com
Subject: Re: [PATCH] drm/amdgpu: Use correct VIEWPORT_DIMENSION for DCN2
Date: Tue, 25 Jan 2022 16:50:01 +0100 [thread overview]
Message-ID: <YfAcKZALAKAMXs/O@kroah.com> (raw)
In-Reply-To: <20220125152111.22515-1-mario.limonciello@amd.com>
On Tue, Jan 25, 2022 at 09:21:11AM -0600, Mario Limonciello wrote:
> For some reason this file isn't using the appropriate register
> headers for DCN headers, which means that on DCN2 we're getting
> the VIEWPORT_DIMENSION offset wrong.
>
> This means that we're not correctly carving out the framebuffer
> memory correctly for a framebuffer allocated by EFI and
> therefore see corruption when loading amdgpu before the display
> driver takes over control of the framebuffer scanout.
>
> Fix this by checking the DCE_HWIP and picking the correct offset
> accordingly.
>
> Long-term we should expose this info from DC as GMC shouldn't
> need to know about DCN registers.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> (cherry picked from commit dc5d4aff2e99c312df8abbe1ee9a731d2913bc1b)
> ---
> This is backported from 5.17-rc1, but doesn't backport cleanly because
> v5.16 changed to IP version harvesting for ASIC detection. 5.15.y doesn't
> have this.
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
What stable tree(s) do you want this applied to?
And what happened to the original signed-off-by's on the original
commit?
thanks,
greg k-h
next prev parent reply other threads:[~2022-01-25 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 15:21 [PATCH] drm/amdgpu: Use correct VIEWPORT_DIMENSION for DCN2 Mario Limonciello
2022-01-25 15:46 ` Limonciello, Mario
2022-01-25 15:50 ` Greg KH [this message]
2022-01-25 15:52 ` Limonciello, Mario
2022-01-27 15:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfAcKZALAKAMXs/O@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Alexander.Deucher@amd.com \
--cc=harry.wentland@amd.com \
--cc=mario.limonciello@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).