Re: [PATCH] drm/amdgpu: Use correct VIEWPORT_DIMENSION for DCN2

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Jan 25, 2022 at 03:52:47PM +0000, Limonciello, Mario wrote:
> [Public]
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Tuesday, January 25, 2022 09:50
> > To: Limonciello, Mario <Mario.Limonciello@amd.com>
> > Cc: stable@vger.kernel.org; Deucher, Alexander
> > <Alexander.Deucher@amd.com>; Wentland, Harry
> > <Harry.Wentland@amd.com>
> > Subject: Re: [PATCH] drm/amdgpu: Use correct VIEWPORT_DIMENSION for
> > DCN2
> > 
> > On Tue, Jan 25, 2022 at 09:21:11AM -0600, Mario Limonciello wrote:
> > > For some reason this file isn't using the appropriate register
> > > headers for DCN headers, which means that on DCN2 we're getting
> > > the VIEWPORT_DIMENSION offset wrong.
> > >
> > > This means that we're not correctly carving out the framebuffer
> > > memory correctly for a framebuffer allocated by EFI and
> > > therefore see corruption when loading amdgpu before the display
> > > driver takes over control of the framebuffer scanout.
> > >
> > > Fix this by checking the DCE_HWIP and picking the correct offset
> > > accordingly.
> > >
> > > Long-term we should expose this info from DC as GMC shouldn't
> > > need to know about DCN registers.
> > >
> > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > > (cherry picked from commit dc5d4aff2e99c312df8abbe1ee9a731d2913bc1b)
> > > ---
> > > This is backported from 5.17-rc1, but doesn't backport cleanly because
> > > v5.16 changed to IP version harvesting for ASIC detection.  5.15.y doesn't
> > > have this.
> > >  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 14 +++++++++++++-
> > >  1 file changed, 13 insertions(+), 1 deletion(-)
> > 
> > What stable tree(s) do you want this applied to?
> > 
> 
> The original commit it was cherry-picked from was CC to @stable and it
> should have applied to 5.16 from that. 
> 
> This fixed commit should go into 5.15.y.

Thanks, now queued up.

> > And what happened to the original signed-off-by's on the original
> > commit?
> 
> I dropped them because I had to change code to do the backport, it didn't seem reasonable
> to me to keep all of their ACK's/signed-off-by's on the code still.
> 
> If that's incorrect, please let me know and I can re-send with the exact same commit message.

Please keep them.  I've fixed this up for now, so no need for a resend.

thanks,

greg k-h