From: Greg KH <gregkh@linuxfoundation.org>
To: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
Cc: stable@vger.kernel.org, Tim Harvey <tharvey@gateworks.com>,
Haibo Chen <haibo.chen@nxp.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 5.4.y] mmc: sdhci-esdhc-imx: disable CMDQ support
Date: Thu, 27 Jan 2022 16:42:58 +0100 [thread overview]
Message-ID: <YfK9gsIvfJ79MP5o@kroah.com> (raw)
In-Reply-To: <20220127103416.53-1-andrey.zhizhikin@leica-geosystems.com>
On Thu, Jan 27, 2022 at 11:34:16AM +0100, Andrey Zhizhikin wrote:
> From: Tim Harvey <tharvey@gateworks.com>
>
> commit adab993c25191b839b415781bdc7173a77315240 upstream.
>
> On IMX SoC's which support CMDQ the following can occur during high a
> high cpu load:
>
> mmc2: cqhci: ============ CQHCI REGISTER DUMP ===========
> mmc2: cqhci: Caps: 0x0000310a | Version: 0x00000510
> mmc2: cqhci: Config: 0x00001001 | Control: 0x00000000
> mmc2: cqhci: Int stat: 0x00000000 | Int enab: 0x00000006
> mmc2: cqhci: Int sig: 0x00000006 | Int Coal: 0x00000000
> mmc2: cqhci: TDL base: 0x8003f000 | TDL up32: 0x00000000
> mmc2: cqhci: Doorbell: 0xbf01dfff | TCN: 0x00000000
> mmc2: cqhci: Dev queue: 0x00000000 | Dev Pend: 0x08000000
> mmc2: cqhci: Task clr: 0x00000000 | SSC1: 0x00011000
> mmc2: cqhci: SSC2: 0x00000001 | DCMD rsp: 0x00000800
> mmc2: cqhci: RED mask: 0xfdf9a080 | TERRI: 0x00000000
> mmc2: cqhci: Resp idx: 0x0000000d | Resp arg: 0x00000000
> mmc2: sdhci: ============ SDHCI REGISTER DUMP ===========
> mmc2: sdhci: Sys addr: 0x7c722000 | Version: 0x00000002
> mmc2: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000020
> mmc2: sdhci: Argument: 0x00018000 | Trn mode: 0x00000023
> mmc2: sdhci: Present: 0x01f88008 | Host ctl: 0x00000030
> mmc2: sdhci: Power: 0x00000002 | Blk gap: 0x00000080
> mmc2: sdhci: Wake-up: 0x00000008 | Clock: 0x0000000f
> mmc2: sdhci: Timeout: 0x0000008f | Int stat: 0x00000000
> mmc2: sdhci: Int enab: 0x107f4000 | Sig enab: 0x107f4000
> mmc2: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000502
> mmc2: sdhci: Caps: 0x07eb0000 | Caps_1: 0x8000b407
> mmc2: sdhci: Cmd: 0x00000d1a | Max curr: 0x00ffffff
> mmc2: sdhci: Resp[0]: 0x00000000 | Resp[1]: 0xffc003ff
> mmc2: sdhci: Resp[2]: 0x328f5903 | Resp[3]: 0x00d07f01
> mmc2: sdhci: Host ctl2: 0x00000088
> mmc2: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xfe179020
> mmc2: sdhci-esdhc-imx: ========= ESDHC IMX DEBUG STATUS DUMP ====
> mmc2: sdhci-esdhc-imx: cmd debug status: 0x2120
> mmc2: sdhci-esdhc-imx: data debug status: 0x2200
> mmc2: sdhci-esdhc-imx: trans debug status: 0x2300
> mmc2: sdhci-esdhc-imx: dma debug status: 0x2400
> mmc2: sdhci-esdhc-imx: adma debug status: 0x2510
> mmc2: sdhci-esdhc-imx: fifo debug status: 0x2680
> mmc2: sdhci-esdhc-imx: async fifo debug status: 0x2750
> mmc2: sdhci: ============================================
>
> For now, disable CMDQ support on the imx8qm/imx8qxp/imx8mm until the
> issue is found and resolved.
>
> Fixes: bb6e358169bf6 ("mmc: sdhci-esdhc-imx: add CMDQ support")
> Fixes: cde5e8e9ff146 ("mmc: sdhci-esdhc-imx: Add an new esdhc_soc_data for i.MX8MM")
> Cc: stable@vger.kernel.org # 5.4.y
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Link: https://lore.kernel.org/r/20211103165415.2016-1-tharvey@gateworks.com
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 2c01e2ebef7a..d97c19ef7583 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -218,8 +218,7 @@ static struct esdhc_soc_data usdhc_imx7ulp_data = {
> static struct esdhc_soc_data usdhc_imx8qxp_data = {
> .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
> - | ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
> - | ESDHC_FLAG_CQHCI,
> + | ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES,
> };
>
> struct pltfm_imx_data {
>
> base-commit: 4aa2e7393e140f434c469bffe478e11cb9c55ed8
> --
> 2.34.1
>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-01-27 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 10:34 [PATCH 5.4.y] mmc: sdhci-esdhc-imx: disable CMDQ support Andrey Zhizhikin
2022-01-27 15:42 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfK9gsIvfJ79MP5o@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adrian.hunter@intel.com \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=haibo.chen@nxp.com \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).