From: Greg KH <gregkh@linuxfoundation.org>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: stable@vger.kernel.org, kabel@kernel.org,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 5.4] net: sfp: ignore disabled SFP node
Date: Sat, 29 Jan 2022 17:12:21 +0100 [thread overview]
Message-ID: <YfVnZVWeew+nC9EH@kroah.com> (raw)
In-Reply-To: <20220129160947.11445-1-marek.behun@nic.cz>
On Sat, Jan 29, 2022 at 05:09:47PM +0100, Marek Behún wrote:
> From: Marek Behún <kabel@kernel.org>
>
> commit 2148927e6ed43a1667baf7c2ae3e0e05a44b51a0 upstream.
>
> Commit ce0aa27ff3f6 ("sfp: add sfp-bus to bridge between network devices
> and sfp cages") added code which finds SFP bus DT node even if the node
> is disabled with status = "disabled". Because of this, when phylink is
> created, it ends with non-null .sfp_bus member, even though the SFP
> module is not probed (because the node is disabled).
>
> We need to ignore disabled SFP bus node.
>
> Fixes: ce0aa27ff3f6 ("sfp: add sfp-bus to bridge between network devices and sfp cages")
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Cc: stable@vger.kernel.org # 2203cbf2c8b5 ("net: sfp: move fwnode parsing into sfp-bus layer")
> Signed-off-by: David S. Miller <davem@davemloft.net>
> [ backport to 5.4 ]
> Signed-off-by: Marek Behún <kabel@kernel.org>
> ---
> drivers/net/phy/phylink.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-01-29 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 12:00 FAILED: patch "[PATCH] net: sfp: ignore disabled SFP node" failed to apply to 5.4-stable tree gregkh
2022-01-29 16:09 ` [PATCH 5.4] net: sfp: ignore disabled SFP node Marek Behún
2022-01-29 16:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfVnZVWeew+nC9EH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=marek.behun@nic.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).