From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC4BC433EF for ; Fri, 18 Feb 2022 19:57:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238398AbiBRT54 (ORCPT ); Fri, 18 Feb 2022 14:57:56 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236675AbiBRT5z (ORCPT ); Fri, 18 Feb 2022 14:57:55 -0500 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A770318 for ; Fri, 18 Feb 2022 11:57:37 -0800 (PST) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 21IJvMhu025645 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Feb 2022 14:57:23 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 509BB15C0036; Fri, 18 Feb 2022 14:57:22 -0500 (EST) Date: Fri, 18 Feb 2022 14:57:22 -0500 From: "Theodore Ts'o" To: Greg KH Cc: Leah Rumancik , stable@vger.kernel.org, Zhang Yi Subject: Re: [PATCH for 5.4 1/3] ext4: check for out-of-order index extents in ext4_valid_extent_entries() Message-ID: References: <20220217225914.40363-1-leah.rumancik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Leah, thanks for doing the backport to 5.4! And Greg, thanks for queuing them up. I note that if we first cherry pick into 4.19.y a fix from 5.2 that probably should have been cc'ed to stable to begin with: 0a944e8a6c66 ("ext4: don't perform block validity checks on the journal inode") Leah's three backports to 5.4 will then apply to 4.19 LTS; I've run regression tests with the cherry-pick of 0a944e8a6c66 and Leah's three backports applied to 4.19.230, and the resulting kernel looks fine and prevents a kernel crash when running ext4/054. Greg, would you prefer that I send the patches for 4.19.y, or do you have what you need to do the cherry pick (all of the cherry picks are clean, and didn't require any manual resolution)? Thanks! - Ted