From: Sasha Levin <sashal@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
linux-stable <stable@vger.kernel.org>,
Sumit Garg <sumit.garg@linaro.org>,
Lars Persson <larper@axis.com>
Subject: Re: stable-rc/queue: 5.15 5.16 arm64 builds failed
Date: Fri, 18 Feb 2022 14:58:37 -0500 [thread overview]
Message-ID: <Yg/6bVfy5cOwpjWa@sashalap> (raw)
In-Reply-To: <Yg+zn6egFCxUZTFX@kroah.com>
On Fri, Feb 18, 2022 at 03:56:31PM +0100, Greg Kroah-Hartman wrote:
>On Fri, Feb 18, 2022 at 03:49:49PM +0100, Jens Wiklander wrote:
>> Hi Naresh,
>>
>> On Fri, Feb 18, 2022 at 3:36 PM Naresh Kamboju
>> <naresh.kamboju@linaro.org> wrote:
>> >
>> > While building stable rc queues for arch arm64 on queue/5.15 and
>> > queue/5.16 the following build errors / warnings were noticed.
>> >
>> > ## Fails
>> > * arm64, build
>> > - gcc-11-defconfig-5e73d44a
>> >
>> > Committing details,
>> > optee: use driver internal tee_context for some rpc
>> > commit aceeafefff736057e8f93f19bbfbef26abd94604 upstream.
>> >
>> >
>> > build error / warning.
>> > drivers/tee/optee/core.c: In function 'optee_remove':
>> > drivers/tee/optee/core.c:591:9: error: implicit declaration of
>> > function 'teedev_close_context'; did you mean
>> > 'tee_client_close_context'? [-Werror=implicit-function-declaration]
>> > 591 | teedev_close_context(optee->ctx);
>> > | ^~~~~~~~~~~~~~~~~~~~
>> > | tee_client_close_context
>> > drivers/tee/optee/core.c: In function 'optee_probe':
>> > drivers/tee/optee/core.c:724:15: error: implicit declaration of
>> > function 'teedev_open' [-Werror=implicit-function-declaration]
>> > 724 | ctx = teedev_open(optee->teedev);
>> > | ^~~~~~~~~~~
>> > drivers/tee/optee/core.c:724:13: warning: assignment to 'struct
>> > tee_context *' from 'int' makes pointer from integer without a cast
>> > [-Wint-conversion]
>> > 724 | ctx = teedev_open(optee->teedev);
>> > | ^
>> > drivers/tee/optee/core.c:726:20: warning: operation on 'rc' may be
>> > undefined [-Wsequence-point]
>> > 726 | rc = rc = PTR_ERR(ctx);
>> > | ~~~^~~~~~~~~~~~~~~~~~~
>> > cc1: some warnings being treated as errors
>> >
>> >
>> >
>>
>> It looks like 1e2c3ef0496e ("tee: export teedev_open() and
>> teedev_close_context()") is missing. I noted the dependency as:
>> Cc: stable@vger.kernel.org # 1e2c3ef0496e tee: export
>> teedev_open() and teedev_close_context()
>> in the commit. Perhaps I've misunderstood how this is supposed to be done.
>
>When doing a backport like this, please be explicit as to what I need to
>do if it is different than just taking the patch you sent me.
>
>I'll try to fix this up later...
I've added the missing commit to 5.15 and 5.16.
--
Thanks,
Sasha
prev parent reply other threads:[~2022-02-18 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 14:36 stable-rc/queue: 5.15 5.16 arm64 builds failed Naresh Kamboju
2022-02-18 14:49 ` Jens Wiklander
2022-02-18 14:56 ` Greg Kroah-Hartman
2022-02-18 15:09 ` Jens Wiklander
2022-02-18 19:58 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg/6bVfy5cOwpjWa@sashalap \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jens.wiklander@linaro.org \
--cc=larper@axis.com \
--cc=naresh.kamboju@linaro.org \
--cc=stable@vger.kernel.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox