From: Greg KH <gregkh@linuxfoundation.org>
To: Brian Geffon <bgeffon@google.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Willis Kung <williskung@google.com>,
Guenter Roeck <groeck@google.com>, Borislav Petkov <bp@suse.de>,
Andy Lutomirski <luto@kernel.org>,
"# v4 . 10+" <stable@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH stable 5.4,5.10] x86/fpu: Correct pkru/xstate inconsistency
Date: Wed, 16 Feb 2022 11:05:31 +0100 [thread overview]
Message-ID: <YgzMa7VcdzRCyYGn@kroah.com> (raw)
In-Reply-To: <CADyq12yuzOPbv+jrdhf8unzsifVXGw31LbW+Sh2tZ3qG=xjGjg@mail.gmail.com>
On Tue, Feb 15, 2022 at 09:01:54PM -0500, Brian Geffon wrote:
> On Tue, Feb 15, 2022 at 4:42 PM Dave Hansen <dave.hansen@intel.com> wrote:
> >
> > On 2/15/22 13:32, Brian Geffon wrote:
> > >> How was this tested, and what do the maintainers of this subsystem
> > >> think? And will you be around to fix the bugs in this when they are
> > >> found?
> > > This has been trivial to reproduce, I've used a small repro which I've
> > > put here: https://gist.github.com/bgaff/9f8cbfc8dd22e60f9492e4f0aff8f04f
> > > , I also was able to reproduce this using the protection_keys self
> > > tests on a 11th Gen Core i5-1135G7.
> >
> > I've got an i7-1165G7, but I'm not seeing any failures on a
> > 5.11 distro kernel.
> >
>
> Hi Dave,
> I suspect the reason you're not seeing it is toolchain related, I'm
> building with clang 14.0.0 and it produces the sequence of
> instructions which use the cached value. Let me know if there is
> anything I can do to help you investigate this further.
Do older versions of clang have this problem?
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-16 10:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 15:36 [PATCH] x86/fpu: Correct pkru/xstate inconsistency Brian Geffon
2022-02-15 15:57 ` Guenter Roeck
2022-02-15 16:19 ` Brian Geffon
2022-02-15 17:02 ` Guenter Roeck
2022-02-15 17:10 ` Dave Hansen
2022-02-15 16:20 ` Greg KH
2022-02-15 17:07 ` Dave Hansen
2022-02-15 17:50 ` Brian Geffon
2022-02-15 17:55 ` Dave Hansen
2022-02-15 19:22 ` [PATCH stable 5.4,5.10] " Brian Geffon
2022-02-15 19:44 ` Greg KH
2022-02-15 21:32 ` Brian Geffon
2022-02-15 21:42 ` Dave Hansen
2022-02-15 21:48 ` Brian Geffon
2022-02-16 2:01 ` Brian Geffon
2022-02-16 10:05 ` Greg KH [this message]
2022-02-16 10:05 ` Greg KH
2022-02-16 15:14 ` Brian Geffon
2022-02-16 15:16 ` Dave Hansen
2022-02-17 13:31 ` Brian Geffon
2022-02-17 16:44 ` Dave Hansen
2022-02-17 20:42 ` Brian Geffon
2022-02-24 15:16 ` Dave Hansen
2022-02-25 12:01 ` Greg KH
2022-02-15 21:14 ` [PATCH] " Guenter Roeck
2022-02-15 21:36 ` Brian Geffon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgzMa7VcdzRCyYGn@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bgeffon@google.com \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=williskung@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox