From: Greg KH <gregkh@linuxfoundation.org>
To: "Kai Lüke" <kailueke@linux.microsoft.com>
Cc: stable@vger.kernel.org
Subject: Re: xfrm regression in 5.10.94
Date: Mon, 28 Feb 2022 18:16:31 +0100 [thread overview]
Message-ID: <Yh0Db4AJA0QBZ3iN@kroah.com> (raw)
In-Reply-To: <e2e9e487-1efb-783f-ca5b-7d0c88f8de7b@linux.microsoft.com>
On Mon, Feb 28, 2022 at 01:22:09PM +0100, Kai Lüke wrote:
> Hi,
>
> in 5.10.94 these two xfrm changes cause userspace programs like Cilium to
> suddenly fail (https://github.com/cilium/cilium/pull/18789):
> - xfrm: interface with if_id 0 should return error
> 8dce43919566f06e865f7e8949f5c10d8c2493f5
> - xfrm: state and policy should fail if XFRMA_IF_ID 0
> 68ac0f3810e76a853b5f7b90601a05c3048b8b54
>
> I see that these changes are a reaction to
> - xfrm: fix disable_xfrm sysctl when used on xfrm interfaces
> 9f8550e4bd9d
> but even if the "wrong" usage caused weird behavior I still wonder if it
> was the right decision to do the changes as part of a bugfix update for an
> LTS kernel.
> What do you think about reverting the changes at least for 5.10?
Why is 5.10 special and newer kernels are not? This change shows up for
them, right? Either this is a regression for all kernel releases and
needs to be resolved, or it is ok for any kernel release.
Please work with the networking developers to either resolve the
regression of determine what needs to be done here for userspace to work
properly.
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-28 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 12:22 xfrm regression in 5.10.94 Kai Lüke
2022-02-28 17:16 ` Greg KH [this message]
2022-03-01 16:34 ` Kai Lueke
2022-03-01 19:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh0Db4AJA0QBZ3iN@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kailueke@linux.microsoft.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox