From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB2DC433EF for ; Wed, 23 Feb 2022 17:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243561AbiBWRyj (ORCPT ); Wed, 23 Feb 2022 12:54:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243553AbiBWRyi (ORCPT ); Wed, 23 Feb 2022 12:54:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DDB42674; Wed, 23 Feb 2022 09:54:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 24CD8B820F8; Wed, 23 Feb 2022 17:54:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81F89C340E7; Wed, 23 Feb 2022 17:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645638847; bh=9cyKoELaNqypOn6SHzTC2b1tlOn9ixroF+zh6jd+RKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tGo9inj5iVBcUOYzna0Lz+mKuY/Uq3s1lV1b4qbYtaPb7GIPZ3bPxN896gGdGLWPS 7tCSMgvvQkyZQZQIEKtj3E4a6QbCG1Uz0W+o65ziGkLou0ZnfEenrqSeN7urJvzmeH vGkyllNhMfmLBSf5ThH3ia4pb1+vYoAsYPbvJi18= Date: Wed, 23 Feb 2022 18:54:05 +0100 From: Greg KH To: Florian Fainelli Cc: stable@vger.kernel.org, sashal@kernel.org, david regan , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Brian Norris , "open list:NAND FLASH SUBSYSTEM" , open list Subject: Re: [PATCH RESEND stable 4.9] mtd: rawnand: brcmnand: Fixed incorrect sub-page ECC status Message-ID: References: <20220223174431.1083-1-f.fainelli@gmail.com> <20220223174431.1083-3-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220223174431.1083-3-f.fainelli@gmail.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Feb 23, 2022 at 09:44:31AM -0800, Florian Fainelli wrote: > From: david regan > > commit 36415a7964711822e63695ea67fede63979054d9 upstream > > The brcmnand driver contains a bug in which if a page (example 2k byte) > is read from the parallel/ONFI NAND and within that page a subpage (512 > byte) has correctable errors which is followed by a subpage with > uncorrectable errors, the page read will return the wrong status of > correctable (as opposed to the actual status of uncorrectable.) > > The bug is in function brcmnand_read_by_pio where there is a check for > uncorrectable bits which will be preempted if a previous status for > correctable bits is detected. > > The fix is to stop checking for bad bits only if we already have a bad > bits status. > > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") > Signed-off-by: david regan > Reviewed-by: Florian Fainelli > Signed-off-by: Miquel Raynal > Link: https://lore.kernel.org/linux-mtd/trinity-478e0c09-9134-40e8-8f8c-31c371225eda-1643237024774@3c-app-mailcom-lxa02 > [florian: make patch apply to 4.14, file was renamed] > Signed-off-by: Florian Fainelli > --- > drivers/mtd/nand/brcmnand/brcmnand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Why is this a RESEND? What happened with the first set? thanks, greg k-h