Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: surenb@google.com, akpm@linux-foundation.org, brauner@kernel.org,
	caoxiaofeng@yulong.com, ccross@google.com,
	chris.hyser@oracle.com, dave.hansen@intel.com, dave@stgolabs.net,
	david@redhat.com, ebiederm@xmission.com, gorcunov@gmail.com,
	hannes@cmpxchg.org, keescook@chromium.org,
	kirill.shutemov@linux.intel.com, legion@kernel.org,
	mhocko@suse.com, pcc@google.com, sumit.semwal@linaro.org,
	torvalds@linux-foundation.org, vbabka@suse.cz,
	willy@infradead.org, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] mm: prevent vm_area_struct::anon_name refcount saturation" failed to apply to 5.15-stable tree
Date: Sun, 6 Mar 2022 16:50:42 -0500	[thread overview]
Message-ID: <YiUssomamBu84L/v@sashalap> (raw)
In-Reply-To: <1646559441105125@kroah.com>

On Sun, Mar 06, 2022 at 10:37:21AM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.15-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 96403e11283def1d1c465c8279514c9a504d8630 Mon Sep 17 00:00:00 2001
>From: Suren Baghdasaryan <surenb@google.com>
>Date: Fri, 4 Mar 2022 20:28:55 -0800
>Subject: [PATCH] mm: prevent vm_area_struct::anon_name refcount saturation
>
>A deep process chain with many vmas could grow really high.  With
>default sysctl_max_map_count (64k) and default pid_max (32k) the max
>number of vmas in the system is 2147450880 and the refcounter has
>headroom of 1073774592 before it reaches REFCOUNT_SATURATED
>(3221225472).
>
>Therefore it's unlikely that an anonymous name refcounter will overflow
>with these defaults.  Currently the max for pid_max is PID_MAX_LIMIT
>(4194304) and for sysctl_max_map_count it's INT_MAX (2147483647).  In
>this configuration anon_vma_name refcount overflow becomes theoretically
>possible (that still require heavy sharing of that anon_vma_name between
>processes).
>
>kref refcounting interface used in anon_vma_name structure will detect a
>counter overflow when it reaches REFCOUNT_SATURATED value but will only
>generate a warning and freeze the ref counter.  This would lead to the
>refcounted object never being freed.  A determined attacker could leak
>memory like that but it would be rather expensive and inefficient way to
>do so.
>
>To ensure anon_vma_name refcount does not overflow, stop anon_vma_name
>sharing when the refcount reaches REFCOUNT_MAX (2147483647), which still
>leaves INT_MAX/2 (1073741823) values before the counter reaches
>REFCOUNT_SATURATED.  This should provide enough headroom for raising the
>refcounts temporarily.

I think that this patch depends on 78db3412833d ("mm: add anonymous vma
name refcounting") which we don't have in any of the stable trees. (is
this why it wasn't tagged for stable?).

-- 
Thanks,
Sasha

  reply	other threads:[~2022-03-06 21:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-06  9:37 FAILED: patch "[PATCH] mm: prevent vm_area_struct::anon_name refcount saturation" failed to apply to 5.15-stable tree gregkh
2022-03-06 21:50 ` Sasha Levin [this message]
2022-03-06 21:58   ` Greg KH
2022-03-06 22:53     ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiUssomamBu84L/v@sashalap \
    --to=sashal@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=caoxiaofeng@yulong.com \
    --cc=ccross@google.com \
    --cc=chris.hyser@oracle.com \
    --cc=dave.hansen@intel.com \
    --cc=dave@stgolabs.net \
    --cc=david@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=gorcunov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=keescook@chromium.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=legion@kernel.org \
    --cc=mhocko@suse.com \
    --cc=pcc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=surenb@google.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox