From: Mark Brown <broonie@kernel.org>
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] soc: soc-dapm: fix two incorrect uses of list iterator
Date: Mon, 28 Mar 2022 17:31:51 +0100 [thread overview]
Message-ID: <YkHi98GDDWNie7GP@sirena.org.uk> (raw)
In-Reply-To: <20220327082138.13696-1-xiam0nd.tong@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Sun, Mar 27, 2022 at 04:21:38PM +0800, Xiaomeng Tong wrote:
> case snd_soc_dapm_pre:
> - if (!w->event)
> + if (!w->event) {
> list_for_each_entry_safe_continue(w, n, list,
> power_list);
> + break;
> + }
This doesn't make much sense. The intent here seems to clearly be to
continue; the loop but this doesn't do that - instead it appears that
continue doesn't actually do the equivalent of a continue but rather
skips over an entry. This should instead be replaced with a plain
continue statement.
THe naming of _continue() needs fixing I think - it's just asking to be
a bug. Fortunately there's very few users.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-28 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 8:21 [PATCH] soc: soc-dapm: fix two incorrect uses of list iterator Xiaomeng Tong
2022-03-28 16:31 ` Mark Brown [this message]
2022-03-29 1:28 ` Xiaomeng Tong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkHi98GDDWNie7GP@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=xiam0nd.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox