From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F284C433F5 for ; Wed, 30 Mar 2022 11:02:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236458AbiC3LEa (ORCPT ); Wed, 30 Mar 2022 07:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343506AbiC3LE1 (ORCPT ); Wed, 30 Mar 2022 07:04:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A25F326D105 for ; Wed, 30 Mar 2022 04:02:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 369C461565 for ; Wed, 30 Mar 2022 11:02:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 499C0C340EC; Wed, 30 Mar 2022 11:02:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648638156; bh=/MDA4aoLXOUv72+xqXS+sDGwXZ++Rc+oM/iFlJJP0rk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FxisMQDCbRY7qcHPH5nWqe1IAFCC+7n2B0eyNdKu+my6/h7hPD+z9zX0vCWhaLDMu QtAeY76k7bNO+zgfooX9BetV6dZ3GoQcOjXBH1egOySVW6TZ86fxpKTCocwwVBPyDh Ktjz9fdUlSY3TZYU+7PAHLgcIRnA/Sqv4qYYImkA= Date: Wed, 30 Mar 2022 13:02:34 +0200 From: Greg KH To: Lee Jones Cc: stable@vger.kernel.org, Xie Yongji , "Michael S . Tsirkin" , Jens Axboe Subject: Re: [PATCH 1/1] virtio-blk: Use blk_validate_block_size() to validate block size Message-ID: References: <20220330105841.464954-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330105841.464954-1-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 30, 2022 at 11:58:41AM +0100, Lee Jones wrote: > From: Xie Yongji > > [ Upstream commit 57a13a5b8157d9a8606490aaa1b805bafe6c37e1 ] > > The block layer can't support a block size larger than > page size yet. And a block size that's too small or > not a power of two won't work either. If a misconfigured > device presents an invalid block size in configuration space, > it will result in the kernel crash something like below: > > [ 506.154324] BUG: kernel NULL pointer dereference, address: 0000000000000008 > [ 506.160416] RIP: 0010:create_empty_buffers+0x24/0x100 > [ 506.174302] Call Trace: > [ 506.174651] create_page_buffers+0x4d/0x60 > [ 506.175207] block_read_full_page+0x50/0x380 > [ 506.175798] ? __mod_lruvec_page_state+0x60/0xa0 > [ 506.176412] ? __add_to_page_cache_locked+0x1b2/0x390 > [ 506.177085] ? blkdev_direct_IO+0x4a0/0x4a0 > [ 506.177644] ? scan_shadow_nodes+0x30/0x30 > [ 506.178206] ? lru_cache_add+0x42/0x60 > [ 506.178716] do_read_cache_page+0x695/0x740 > [ 506.179278] ? read_part_sector+0xe0/0xe0 > [ 506.179821] read_part_sector+0x36/0xe0 > [ 506.180337] adfspart_check_ICS+0x32/0x320 > [ 506.180890] ? snprintf+0x45/0x70 > [ 506.181350] ? read_part_sector+0xe0/0xe0 > [ 506.181906] bdev_disk_changed+0x229/0x5c0 > [ 506.182483] blkdev_get_whole+0x6d/0x90 > [ 506.183013] blkdev_get_by_dev+0x122/0x2d0 > [ 506.183562] device_add_disk+0x39e/0x3c0 > [ 506.184472] virtblk_probe+0x3f8/0x79b [virtio_blk] > [ 506.185461] virtio_dev_probe+0x15e/0x1d0 [virtio] > > So let's use a block layer helper to validate the block size. > > Signed-off-by: Xie Yongji > Acked-by: Michael S. Tsirkin > Link: https://lore.kernel.org/r/20211026144015.188-5-xieyongji@bytedance.com > Signed-off-by: Jens Axboe > Signed-off-by: Lee Jones > --- > drivers/block/virtio_blk.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) What stable tree(s) are you wanting this backported to? thanks, greg k-h