From: Greg KH <gregkh@linuxfoundation.org>
To: Joshua Freedman <freedman.joshua@gmail.com>
Cc: lis8215@gmail.com, paul@crapouillou.net, stable@vger.kernel.org,
sboyd@kernel.org
Subject: Re: kernel 5.16.12 and above broke yoga c930 sound and mic
Date: Wed, 30 Mar 2022 10:26:01 +0200 [thread overview]
Message-ID: <YkQUGVC3MBSnc2LI@kroah.com> (raw)
In-Reply-To: <CAJQ3t4RxYXkREhwBb_JgYj4=ty+VtnV9m65U79ZLbmmj4mN7WA@mail.gmail.com>
On Wed, Mar 30, 2022 at 03:34:34AM -0400, Joshua Freedman wrote:
> Hi, I noticed my audio and mic stopped working on my yoga c930 on 5.16.12
> and newer. 5.16.11 was ok. On 5.16.12 and above I get a dummy output and
> no mic.
>
> Anything we can do about that? Thanks.
>
> I'm not a git guy so I just looked at the changlogs and this was the only
> audio one in 5.16.12. I could be wrong in the ID though.
>
> commit 6b0d719ffed1c21c1a2e473301fd95f78cd35c9e
> Author: Siarhei Volkau <lis8215@gmail.com>
> Date: Sat Feb 5 20:18:49 2022 +0300
>
> clk: jz4725b: fix mmc0 clock gating
>
> commit 2f0754f27a230fee6e6d753f07585cee03bedfe3 upstream.
>
> The mmc0 clock gate bit was mistakenly assigned to "i2s" clock.
> You can find that the same bit is assigned to "mmc0" too.
> It leads to mmc0 hang for a long time after any sound activity
> also it prevented PM_SLEEP to work properly.
> I guess it was introduced by copy-paste from jz4740 driver
> where it is really controls I2S clock gate.
>
> Fixes: 226dfa4726eb ("clk: Add Ingenic jz4725b CGU driver")
> Signed-off-by: Siarhei Volkau <lis8215@gmail.com>
> Tested-by: Siarhei Volkau <lis8215@gmail.com>
> Reviewed-by: Paul Cercueil <paul@crapouillou.net>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/20220205171849.687805-2-lis8215@gmail.com
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
If you revert this does your machine work properly? Is 5.17 also broken
for you due to this change, or does it work properly?
thanks,
greg k-h
next parent reply other threads:[~2022-03-30 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJQ3t4RxYXkREhwBb_JgYj4=ty+VtnV9m65U79ZLbmmj4mN7WA@mail.gmail.com>
2022-03-30 8:26 ` Greg KH [this message]
[not found] ` <CAJQ3t4TqK+q5zeHCQ2uxGvhT4q0Bpe6PBuDTm28HqyHwH5mzhQ@mail.gmail.com>
2022-03-30 9:47 ` kernel 5.16.12 and above broke yoga c930 sound and mic Greg KH
[not found] ` <CAJQ3t4SnNyHEaWizzVDbaMSdHDRe9wHGx2RdgJJea=G4sFmdnw@mail.gmail.com>
2022-03-30 11:02 ` Greg KH
[not found] ` <CAJQ3t4Rg2WhDoynG=NmHX5dgt3u5BB3gfpAbskb4gQ_R8qxmxA@mail.gmail.com>
2022-04-01 10:46 ` Greg KH
2022-04-01 10:47 ` Greg KH
[not found] ` <CAJQ3t4Q3ToQ9_Y3qc2WTsgxD9D14F-x4X5gTDB-mEWXqbeCk=g@mail.gmail.com>
2022-04-11 9:37 ` Greg KH
[not found] ` <CAJQ3t4Sf3fLqxrpwvmZ9KCgfXVTdaxaUcG1U_gEK+xDo3+BHxQ@mail.gmail.com>
2022-04-22 12:09 ` Greg KH
2022-03-30 8:56 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkQUGVC3MBSnc2LI@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=freedman.joshua@gmail.com \
--cc=lis8215@gmail.com \
--cc=paul@crapouillou.net \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox