[PATCH 0/1] drm/simpledrm: Add "panel orientation" property on non-upright mounted LCD panels

[PATCH 0/1] drm/simpledrm: Add "panel orientation" property on non-upright mounted LCD panels

[Hans de Goede]

Hi Greg,

Fedora 36 has switched from efifb to simpledrm as the pre-native-GPU driver
fb provider and the lack of this patch is causing issues for devices with
non up-right mounted LCD panels (1), can you please add this to the 5.17 stable
series?

Regards,

Hans

1) https://bugzilla.redhat.com/show_bug.cgi?id=2071134


Hans de Goede (1):
  drm/simpledrm: Add "panel orientation" property on non-upright mounted
    LCD panels

 drivers/gpu/drm/tiny/simpledrm.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.35.1

[PATCH 1/1] drm/simpledrm: Add "panel orientation" property on non-upright mounted LCD panels

[Hans de Goede]

commit 94fa115f7b28a3f02611499175e134f0a823b686 upstream.

Some devices use e.g. a portrait panel in a standard laptop casing made
for landscape panels. efifb calls drm_get_panel_orientation_quirk() and
sets fb_info.fbcon_rotate_hint to make fbcon rotate the console so that
it shows up-right instead of on its side.

When switching to simpledrm the fbcon renders on its side. Call the
drm_connector_set_panel_orientation_with_quirk() helper to add
a "panel orientation" property on devices listed in the quirk table,
to make the fbcon (and aware userspace apps) rotate the image to
display properly.

Cc: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20220221220045.11958-1-hdegoede@redhat.com
---
 drivers/gpu/drm/tiny/simpledrm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
index d191e87a37b5..f5b8e864a5cd 100644
--- a/drivers/gpu/drm/tiny/simpledrm.c
+++ b/drivers/gpu/drm/tiny/simpledrm.c
@@ -810,6 +810,9 @@ static int simpledrm_device_init_modeset(struct simpledrm_device *sdev)
 	if (ret)
 		return ret;
 	drm_connector_helper_add(connector, &simpledrm_connector_helper_funcs);
+	drm_connector_set_panel_orientation_with_quirk(connector,
+						       DRM_MODE_PANEL_ORIENTATION_UNKNOWN,
+						       mode->hdisplay, mode->vdisplay);
 
 	formats = simpledrm_device_formats(sdev, &nformats);
 
-- 
2.35.1

Re: [PATCH 0/1] drm/simpledrm: Add "panel orientation" property on non-upright mounted LCD panels

[Greg Kroah-Hartman]

On Sat, Apr 02, 2022 at 11:30:28AM +0200, Hans de Goede wrote:
> Hi Greg,
> 
> Fedora 36 has switched from efifb to simpledrm as the pre-native-GPU driver
> fb provider and the lack of this patch is causing issues for devices with
> non up-right mounted LCD panels (1), can you please add this to the 5.17 stable
> series?
> 
> Regards,
> 
> Hans
> 
> 1) https://bugzilla.redhat.com/show_bug.cgi?id=2071134
> 
> 
> Hans de Goede (1):
>   drm/simpledrm: Add "panel orientation" property on non-upright mounted
>     LCD panels
> 
>  drivers/gpu/drm/tiny/simpledrm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> -- 
> 2.35.1
> 

Now queued up, thanks.

greg k-h