From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA814C4332F for ; Sat, 2 Apr 2022 19:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245432AbiDBTjk (ORCPT ); Sat, 2 Apr 2022 15:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242352AbiDBTjj (ORCPT ); Sat, 2 Apr 2022 15:39:39 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10F4DC627E for ; Sat, 2 Apr 2022 12:37:47 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id u3so8756482wrg.3 for ; Sat, 02 Apr 2022 12:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=astier-eu.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=80wofTwbxJqppPX/gKsG/MIQEWwl0NPubl49Nu0tXCc=; b=sWKLVd+x2DbLhiDnbts76cHlkFQEQHsmlx6qJ6nxYCvQlpVs+QDMyZC4OAVm5yENNZ dmTE3oRApLfp54aGaApEC3lWdpn3tW7makqGRG1e3fUJr9BjZ3pr6B9FuJbTXY2XGkfj CHjIP/7S3u7QgdxB2gEMBijjDRZFO7QnsThw8owkGCiYzw6JnxUlkENZmy1ijsCykVEv 0nCqaamI/cFQcVMRYFwRsY9eo7yz15n7nqrSHvEtN9nRNrm8ndytQkH9r2GOcl7YAfuL mXPCrq0v5Y+rWzbGW4RT1gnupsb3D1aRitry+HPWnrUqB+mKphJdfPD3vwH7LjZ6hL+o VkOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=80wofTwbxJqppPX/gKsG/MIQEWwl0NPubl49Nu0tXCc=; b=efJotIFtOeyOs/hN12xRd0sdIGBaZsc/jynmjzdcxy4RRkt2I4tnpHyC9Cv/3kU98n ZE8lTlxp7HO3YyQRyUu3A2v8Jqn2MSP/UM1YJ+Aq4p9+01lSXNOwdcl23JiqzPsGQ/kp 5TPy8pe2JedQaaeY0+PHPNUUIcrMaiQlO/JqOiGCvXfkXRo9C8yk15mNLy/oYB3t3+Ju KxvusLYYVXJkxdX9At79lLqJAWl4UfYdyMixvClrb6atWQM6mPtQUw2kDjr55J/Mv291 M+RX5ChfCGthBv6HLy/4goeKIpRV9E5MgMD7A2W/6PkjWsi6rUw96GT4rBUPLtMTS39m /sJw== X-Gm-Message-State: AOAM530qnMeugqV4OM0kP55v2sMY1o1OwJ+r93vlFV8xqXcU6Qe5u+Ce zuMGB/IQUiHxjmURhUDaAu/vrg== X-Google-Smtp-Source: ABdhPJzTVam/vm4DE1k8FMuXemOpPbS4zYtmup8fzVrX6VI7CelNUeeNzpxvBUgZEQYY2gni86+dAw== X-Received: by 2002:a5d:6d0c:0:b0:204:d77:313a with SMTP id e12-20020a5d6d0c000000b002040d77313amr12191546wrq.405.1648928265626; Sat, 02 Apr 2022 12:37:45 -0700 (PDT) Received: from bilrost ([2a01:e0a:28f:75b0:dea6:32ff:fe0d:99f9]) by smtp.gmail.com with ESMTPSA id az26-20020adfe19a000000b00204154a1d1fsm5262746wrb.88.2022.04.02.12.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 12:37:45 -0700 (PDT) Date: Sat, 2 Apr 2022 21:37:43 +0200 From: Anisse Astier To: Hans de Goede Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jani Nikula , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org Subject: Re: [PATCH AUTOSEL 5.17 001/149] drm: Add orientation quirk for GPD Win Max Message-ID: References: <20220401142536.1948161-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Le Sat, Apr 02, 2022 at 11:14:58AM +0200, Hans de Goede a écrit : > Hi, > > On 4/1/22 22:33, Anisse Astier wrote: > > Hi Sasha, > > > > Le Fri, Apr 01, 2022 at 10:23:08AM -0400, Sasha Levin a écrit : > >> From: Anisse Astier > >> > >> [ Upstream commit 0b464ca3e0dd3cec65f28bc6d396d82f19080f69 ] > >> > >> Panel is 800x1280, but mounted on a laptop form factor, sideways. > >> > >> Signed-off-by: Anisse Astier > >> Reviewed-by: Hans de Goede > >> Signed-off-by: Jani Nikula > >> Link: https://patchwork.freedesktop.org/patch/msgid/20211229222200.53128-3-anisse@astier.eu > >> Signed-off-by: Sasha Levin > > > > I don't think this patch will be very useful, because it won't fix the > > device's display orientation without the previous patch it came with, > > titled "drm/i915/opregion: add support for mailbox #5 EDID" > > (e35d8762b04f89f9f5a188d0c440d3a2c1d010ed); while I'd like both to be > > added > > Well actually it will already put e.g. the text console the right way up > since efifb also uses this quirks and gives a hint to fbcon to rotate > the text. So it is not entirely useless. > > And since all quirks added to drivers/gpu/drm/drm_panel_orientation_quirks.c > typically get backported having this one in place now will avoid conflicts > with future backports. > > That combined with not really seeing a downside to already having > this in place even without the i915 support being sorted out makes > me lean more towards the direction of believing that having this > in 5.17 is fine... > Good points; lets's keep it in the stable queues. Thanks, Anisse