From: Greg KH <gregkh@linuxfoundation.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, stable@vger.kernel.org,
Hangyu Hua <hbh25y@gmail.com>
Subject: Re: [PATCH] can: usb_8dev: usb_8dev_start_xmit(): fix double dev_kfree_skb() in error path
Date: Tue, 5 Apr 2022 07:11:13 +0200 [thread overview]
Message-ID: <YkvPcRuSxbeXZn9I@kroah.com> (raw)
In-Reply-To: <20220404192536.1243729-1-mkl@pengutronix.de>
On Mon, Apr 04, 2022 at 09:25:36PM +0200, Marc Kleine-Budde wrote:
> From: Hangyu Hua <hbh25y@gmail.com>
>
> commit 3d3925ff6433f98992685a9679613a2cc97f3ce2 upstream.
>
> There is no need to call dev_kfree_skb() when usb_submit_urb() fails
> because can_put_echo_skb() deletes original skb and
> can_free_echo_skb() deletes the cloned skb.
>
> Fixes: 0024d8ad1639 ("can: usb_8dev: Add support for USB2CAN interface from 8 devices")
> Link: https://lore.kernel.org/all/20220311080614.45229-1-hbh25y@gmail.com
> Cc: stable@vger.kernel.org
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> Hello Greg, hello Sasha,
>
> This is
>
> | 3d3925ff6433 can: usb_8dev: usb_8dev_start_xmit(): fix double dev_kfree_skb() in error path
>
> ported to v5.10.109.
This, and the other backport, now queued up, thanks!
greg k-h
prev parent reply other threads:[~2022-04-05 5:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 19:25 [PATCH] can: usb_8dev: usb_8dev_start_xmit(): fix double dev_kfree_skb() in error path Marc Kleine-Budde
2022-04-05 5:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkvPcRuSxbeXZn9I@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hbh25y@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox