public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>
Cc: stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: 5.15 request: properly backport VFS/XFS syncfs error handling
Date: Mon, 18 Apr 2022 13:45:06 +0200	[thread overview]
Message-ID: <Yl1PQkQDfnA0Jauv@kroah.com> (raw)
In-Reply-To: <8997252f-0196-97aa-659e-34524b7b3593@applied-asynchrony.com>

On Fri, Apr 15, 2022 at 02:10:46PM +0200, Holger Hoffstätte wrote:
> 
> I noticed that our autobot recently backported parts of a series which
> fixed XFS syncfs error handling [1]. Unfortunately - due to missing
> requirements - it only managed to merge those patches which do not
> actually fix anything.
> 
> This can be repaired by applying the prerequisites and then the missing
> parts of the original series, namely in order:
> 
>   9a208ba5c9af fs: remove __sync_filesystem
>   70164eb6ccb7 block: remove __sync_blockdev
>   1e03a36bdff4 block: simplify the block device syncing code
>   5679897eb104 vfs: make sync_filesystem return errors from ->sync_fs
>   2d86293c7075 xfs: return errors in xfs_fs_sync_fs
> 
> With all that we could also put a cherry on top and merge:
> 
>   b97cca3ba909 xfs: only bother with sync_filesystem during readonly remount
> 
> but that's just a touchup and not a real bugfix, so probably optional.

Can we get an ack from the XFS developers that this is ok to do?
Without that, we can't apply xfs patches to the stable trees.

thanks,

greg k-h

  reply	other threads:[~2022-04-18 11:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15 12:10 5.15 request: properly backport VFS/XFS syncfs error handling Holger Hoffstätte
2022-04-18 11:45 ` Greg KH [this message]
2022-04-18 20:31   ` Darrick J. Wong
2022-04-18 21:52     ` Holger Hoffstätte
2022-04-20 14:51       ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yl1PQkQDfnA0Jauv@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=djwong@kernel.org \
    --cc=holger@applied-asynchrony.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox