Re: kernel 5.16.12 and above broke yoga c930 sound and mic

Re: kernel 5.16.12 and above broke yoga c930 sound and mic

[Greg KH]

On Wed, Mar 30, 2022 at 03:34:34AM -0400, Joshua Freedman wrote:
> Hi, I noticed my audio and mic stopped working on my yoga c930 on 5.16.12
> and newer. 5.16.11 was ok.   On 5.16.12 and above I get a dummy output and
> no mic.
> 
> Anything we can do about that?  Thanks.
> 
> I'm not a git guy so I just looked at the changlogs and this was the only
> audio one in 5.16.12.  I could be wrong in the ID though.
> 
> commit 6b0d719ffed1c21c1a2e473301fd95f78cd35c9e
> Author: Siarhei Volkau <lis8215@gmail.com>
> Date:   Sat Feb 5 20:18:49 2022 +0300
> 
>     clk: jz4725b: fix mmc0 clock gating
> 
>     commit 2f0754f27a230fee6e6d753f07585cee03bedfe3 upstream.
> 
>     The mmc0 clock gate bit was mistakenly assigned to "i2s" clock.
>     You can find that the same bit is assigned to "mmc0" too.
>     It leads to mmc0 hang for a long time after any sound activity
>     also it  prevented PM_SLEEP to work properly.
>     I guess it was introduced by copy-paste from jz4740 driver
>     where it is really controls I2S clock gate.
> 
>     Fixes: 226dfa4726eb ("clk: Add Ingenic jz4725b CGU driver")
>     Signed-off-by: Siarhei Volkau <lis8215@gmail.com>
>     Tested-by: Siarhei Volkau <lis8215@gmail.com>
>     Reviewed-by: Paul Cercueil <paul@crapouillou.net>
>     Cc: stable@vger.kernel.org
>     Link: https://lore.kernel.org/r/20220205171849.687805-2-lis8215@gmail.com
>     Signed-off-by: Stephen Boyd <sboyd@kernel.org>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 

If you revert this does your machine work properly?  Is 5.17 also broken
for you due to this change, or does it work properly?

thanks,

greg k-h

Re: kernel 5.16.12 and above broke yoga c930 sound and mic

[Greg KH]

On Wed, Mar 30, 2022 at 05:42:45AM -0400, Joshua Freedman wrote:
> I just re-verified all this:
> 
> For audio and mic:
> 5.17.1 is broken.  Dummy Output.  5.16.12 is also dummy output.
> 5.16.11 was the last working version.   5.16.11-76051611-generic

Great, can you use 'git bisect' to track down the exact commit that
causes problems?  Odds are it's not this one, but perhaps an audio
change?

thanks,

greg k-h

Re: kernel 5.16.12 and above broke yoga c930 sound and mic

[Greg KH]

On Wed, Mar 30, 2022 at 06:28:33AM -0400, Joshua Freedman wrote:
> I'm a mortgage broker but I can figure this out.
> 
> Am I doing this:
> git clone git://
> git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-stable
> 
> and then git good and bad for for 5.16.11 and 5.16.12 and putting that to a
> log file that you can use?

Yes, that is exactly right!

thanks,

greg k-h

Re: kernel 5.16.12 and above broke yoga c930 sound and mic

[Greg KH]

On Wed, Mar 30, 2022 at 04:54:53PM -0400, Joshua Freedman wrote:
> This felt really anti-climactic haha,  but hopefully it's useful?
> cat bisect.log
> Bisecting: 81 revisions left to test after this (roughly 6 steps)
> [770aac3c84e0c83a19985413fa9fbfc126cc0ff6] net: mdio-ipq4019: add delay
> after clock enable

Ok, great!  Can you start a new thread and add the developers of that
change to to it to help track down the issue?

thanks,

greg k-h

Re: kernel 5.16.12 and above broke yoga c930 sound and mic

[Greg KH]

On Wed, Mar 30, 2022 at 04:54:53PM -0400, Joshua Freedman wrote:
> This felt really anti-climactic haha,  but hopefully it's useful?
> cat bisect.log
> Bisecting: 81 revisions left to test after this (roughly 6 steps)
> [770aac3c84e0c83a19985413fa9fbfc126cc0ff6] net: mdio-ipq4019: add delay
> after clock enable

Wait, you still have more steps to go here.  Did you test this kernel?
If so, you need to continue using 'git bisect good' and 'git bisect bad'
to find the offending commit.  This looks just like the first step?

thanks,

greg k-h

Re: kernel 5.16.12 and above broke yoga c930 sound and mic

[Greg KH]

On Fri, Apr 08, 2022 at 07:53:42PM -0400, Joshua Freedman wrote:
> I got the first bisect done, but not sure what do bisect after that.....

What is the result, good or bad?  What does 'git bisect log' show?

thanks,

greg k-h

Re: kernel 5.16.12 and above broke yoga c930 sound and mic

[Greg KH]

On Fri, Apr 22, 2022 at 07:09:34AM -0400, Joshua Freedman wrote:
> The kernel I was using as good for audio is now missing; It was
> 5.16.11-76051611-generic But the only release avail now is
> 5.16.11-051611-generic and  audio does not work.

Those look like distro-specific kernels, please contact your distro for
support of this, there is nothing we can do here about them.

good luck!

greg k-h

Re: kernel 5.16.12 and above broke yoga c930 sound and mic

[Paul Cercueil]

Hi Joshua,

Le mer., mars 30 2022 at 03:34:34 -0400, Joshua Freedman 
<freedman.joshua@gmail.com> a écrit :
> Hi, I noticed my audio and mic stopped working on my yoga c930 on 
> 5.16.12 and newer. 5.16.11 was ok.   On 5.16.12 and above I get a 
> dummy output and no mic.
> 
> Anything we can do about that?  Thanks.
> 
> I'm not a git guy so I just looked at the changlogs and this was the 
> only audio one in 5.16.12.  I could be wrong in the ID though.

This commit changes the clocks on the JZ4725B SoC, there is just no way 
for it to be the cause of your problem.

Cheers,
-Paul

> commit 6b0d719ffed1c21c1a2e473301fd95f78cd35c9e
> Author: Siarhei Volkau <lis8215@gmail.com>
> Date:   Sat Feb 5 20:18:49 2022 +0300
> 
>     clk: jz4725b: fix mmc0 clock gating
> 
>     commit 2f0754f27a230fee6e6d753f07585cee03bedfe3 upstream.
> 
>     The mmc0 clock gate bit was mistakenly assigned to "i2s" clock.
>     You can find that the same bit is assigned to "mmc0" too.
>     It leads to mmc0 hang for a long time after any sound activity
>     also it  prevented PM_SLEEP to work properly.
>     I guess it was introduced by copy-paste from jz4740 driver
>     where it is really controls I2S clock gate.
> 
>     Fixes: 226dfa4726eb ("clk: Add Ingenic jz4725b CGU driver")
>     Signed-off-by: Siarhei Volkau <lis8215@gmail.com>
>     Tested-by: Siarhei Volkau <lis8215@gmail.com>
>     Reviewed-by: Paul Cercueil <paul@crapouillou.net>
>     Cc: stable@vger.kernel.org
>     Link: 
> https://lore.kernel.org/r/20220205171849.687805-2-lis8215@gmail.com
>     Signed-off-by: Stephen Boyd <sboyd@kernel.org>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> 
> --
> 
> 
> Joshua Freedman
> 
> President
> 
> P: +19168060052
> 
> 49 Sample BR RD
> 
> Mechanicsburg, PA 17050-2386
> 
> Fix & Flip Rehab Financing <31 Unit
> 
> 
> 
> 
> PGPKEY
>