stable 5.10: please revert c4dc584a2d4c8d74b054f09d67e0a076767bdee5

stable 5.10: please revert c4dc584a2d4c8d74b054f09d67e0a076767bdee5

[Randy Dunlap]

According to https://bugzilla.kernel.org/show_bug.cgi?id=215823,
c4dc584a2d4c8d74b054f09d67e0a076767bdee5 ("hv: utils: add PTP_1588_CLOCK to Kconfig to fix build")
is a problem for 5.10 since CONFIG_PTP_1588_CLOCK_OPTIONAL does not exist in 5.10.
This prevents the hyper-V NIC timestamping from working, so please revert that commit.

-- 
~Randy

Re: stable 5.10: please revert c4dc584a2d4c8d74b054f09d67e0a076767bdee5

[Sasha Levin]

On Sat, Apr 09, 2022 at 09:07:51AM -0700, Randy Dunlap wrote:
>According to https://bugzilla.kernel.org/show_bug.cgi?id=215823,
>c4dc584a2d4c8d74b054f09d67e0a076767bdee5 ("hv: utils: add PTP_1588_CLOCK to Kconfig to fix build")
>is a problem for 5.10 since CONFIG_PTP_1588_CLOCK_OPTIONAL does not exist in 5.10.
>This prevents the hyper-V NIC timestamping from working, so please revert that commit.

I've reverted it, thanks for the report.

-- 
Thanks,
Sasha

Re: stable 5.10: please revert c4dc584a2d4c8d74b054f09d67e0a076767bdee5

[Greg Kroah-Hartman]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

On Thu, Apr 14, 2022 at 01:50:05PM +0800, cam enih wrote:
> thanks everyone.
> 
> two suggestions:
> 
> 1. To avoid this issue from future dot builds of LTS, i would suggest to
> avoid MRs of any config/module dependency changes, unless the scope of
> impact limits to the scope of MR itself.

What is a "mr"?

> 2. this issue can fail-fast by checking the dependency in compile time.

And how could we have tested this?

confused,

greg k-h

Re: stable 5.10: please revert c4dc584a2d4c8d74b054f09d67e0a076767bdee5

[Greg Kroah-Hartman]

On Thu, Apr 14, 2022 at 03:00:30PM +0800, cam enih wrote:
> sorry for confusion.

Again, please do not top-post.

> 1. MR=merge request;

We do not have merge requests in the kernel, so I do not understand what
you are saying we do differently here.

> 2. In this case, the change depends on a non-existing config option which I
> believe can be detected at compile time.

Specifically, please show us how we should have caught this so we can do
that in the future.  I do not see how this can be detected at compile
time as it is no different from a normal config option not being
selected.

thanks,

greg k-h