Allow playing dead in C3 for 5.15.y

Allow playing dead in C3 for 5.15.y

[Limonciello, Mario]

[Public]

Hi,

A change went into 5.17 to allow CPUs to play dead in the C3 state which fixed freezes on s2idle entry if a CPU is offlined by a user.
This has had some time to bake now, and a regression was identified on an ancient machine that is now fixed.

Can you please backport these commits to 5.15.y to fix that problem and avoid the regression?
commit d6b88ce2eb9d2698eb24451eb92c0a1649b17bb1 ("ACPI: processor idle: Allow playing dead in C3 state")
commit 0f00b1b00a44bf3b5e905dabfde2d51c490678ad ("ACPI: processor: idle: fix lockup regression on 32-bit ThinkPad T40").

Thank you!

Re: Allow playing dead in C3 for 5.15.y

[Greg KH]

On Tue, Apr 12, 2022 at 10:15:37PM +0000, Limonciello, Mario wrote:
> [Public]
> 
> Hi,
> 
> A change went into 5.17 to allow CPUs to play dead in the C3 state which fixed freezes on s2idle entry if a CPU is offlined by a user.
> This has had some time to bake now, and a regression was identified on an ancient machine that is now fixed.
> 
> Can you please backport these commits to 5.15.y to fix that problem and avoid the regression?
> commit d6b88ce2eb9d2698eb24451eb92c0a1649b17bb1 ("ACPI: processor idle: Allow playing dead in C3 state")

Now queued up.

> commit 0f00b1b00a44bf3b5e905dabfde2d51c490678ad ("ACPI: processor: idle: fix lockup regression on 32-bit ThinkPad T40").

There is no such commit in Linus's tree :(

thanks,

greg k-h

RE: Allow playing dead in C3 for 5.15.y

[Limonciello, Mario]

[AMD Official Use Only]



> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Thursday, April 14, 2022 05:57
> To: Limonciello, Mario <Mario.Limonciello@amd.com>
> Cc: stable@vger.kernel.org; Gong, Richard <Richard.Gong@amd.com>
> Subject: Re: Allow playing dead in C3 for 5.15.y
> 
> On Tue, Apr 12, 2022 at 10:15:37PM +0000, Limonciello, Mario wrote:
> > [Public]
> >
> > Hi,
> >
> > A change went into 5.17 to allow CPUs to play dead in the C3 state which
> fixed freezes on s2idle entry if a CPU is offlined by a user.
> > This has had some time to bake now, and a regression was identified on an
> ancient machine that is now fixed.
> >
> > Can you please backport these commits to 5.15.y to fix that problem and
> avoid the regression?
> > commit d6b88ce2eb9d2698eb24451eb92c0a1649b17bb1 ("ACPI: processor
> idle: Allow playing dead in C3 state")
> 
> Now queued up.
> 
> > commit 0f00b1b00a44bf3b5e905dabfde2d51c490678ad ("ACPI: processor:
> idle: fix lockup regression on 32-bit ThinkPad T40").

My apologies; I must have had two references in my tree.  The correct hash is 
bfe55a1f7fd6bfede16078bf04c6250fbca11588

> 
> There is no such commit in Linus's tree :(
> 
> thanks,
> 
> greg k-h

Re: Allow playing dead in C3 for 5.15.y

[Greg KH]

On Thu, Apr 14, 2022 at 12:59:09PM +0000, Limonciello, Mario wrote:
> [AMD Official Use Only]
> 
> 
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Thursday, April 14, 2022 05:57
> > To: Limonciello, Mario <Mario.Limonciello@amd.com>
> > Cc: stable@vger.kernel.org; Gong, Richard <Richard.Gong@amd.com>
> > Subject: Re: Allow playing dead in C3 for 5.15.y
> > 
> > On Tue, Apr 12, 2022 at 10:15:37PM +0000, Limonciello, Mario wrote:
> > > [Public]
> > >
> > > Hi,
> > >
> > > A change went into 5.17 to allow CPUs to play dead in the C3 state which
> > fixed freezes on s2idle entry if a CPU is offlined by a user.
> > > This has had some time to bake now, and a regression was identified on an
> > ancient machine that is now fixed.
> > >
> > > Can you please backport these commits to 5.15.y to fix that problem and
> > avoid the regression?
> > > commit d6b88ce2eb9d2698eb24451eb92c0a1649b17bb1 ("ACPI: processor
> > idle: Allow playing dead in C3 state")
> > 
> > Now queued up.
> > 
> > > commit 0f00b1b00a44bf3b5e905dabfde2d51c490678ad ("ACPI: processor:
> > idle: fix lockup regression on 32-bit ThinkPad T40").
> 
> My apologies; I must have had two references in my tree.  The correct hash is 
> bfe55a1f7fd6bfede16078bf04c6250fbca11588

That worked, thanks.