From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D7AC433F5 for ; Thu, 14 Apr 2022 16:13:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234212AbiDNQPf (ORCPT ); Thu, 14 Apr 2022 12:15:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350195AbiDNQBD (ORCPT ); Thu, 14 Apr 2022 12:01:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43A43ECC52; Thu, 14 Apr 2022 08:47:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C465361E99; Thu, 14 Apr 2022 15:47:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E391C385A5; Thu, 14 Apr 2022 15:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649951246; bh=2gsQ7EAJ+8S2HiqID3+j368chb8mzo9RyvY6eKDvjNY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ey7+8C+ttg7ZllIfeR45UgXIQjB3WSgNtRsBFH0UrsO1ycge/O1ZTqe3kqmcXvSZG w7iZsvTtRURlxFnVTNgnxn52PjGsaYjJE5lBIyAzOekKTAfAzOQH5nlhixYdoEsbR4 tqikMkRAsWKSW6sUEyuQnEdJa684lOmBfYP97wq8= Date: Thu, 14 Apr 2022 17:47:23 +0200 From: Greg Kroah-Hartman To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel test robot , Arnd Bergmann , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , linux-hyperv@vger.kernel.org, Michael Kelley , Petr =?utf-8?Q?=C5=A0tetiar?= Subject: Re: [PATCH 5.4 004/475] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build Message-ID: References: <20220414110855.141582785@linuxfoundation.org> <20220414110855.274446341@linuxfoundation.org> <75a7b583-187d-569d-5ed0-2bb0e1b1ec7b@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <75a7b583-187d-569d-5ed0-2bb0e1b1ec7b@infradead.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Apr 14, 2022 at 08:32:26AM -0700, Randy Dunlap wrote: > > > On 4/14/22 06:06, Greg Kroah-Hartman wrote: > > From: Randy Dunlap > > > > commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 upstream. > > > > The hyperv utilities use PTP clock interfaces and should depend a > > a kconfig symbol such that they will be built as a loadable module or > > builtin so that linker errors do not happen. > > > > Prevents these build errors: > > > > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': > > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' > > ld: drivers/hv/hv_util.o: in function `hv_timesync_init': > > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' > > > > Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source") > > Signed-off-by: Randy Dunlap > > Reported-by: kernel test robot > > Cc: Arnd Bergmann > > Cc: "K. Y. Srinivasan" > > Cc: Haiyang Zhang > > Cc: Stephen Hemminger > > Cc: Wei Liu > > Cc: Dexuan Cui > > Cc: linux-hyperv@vger.kernel.org > > Cc: Greg Kroah-Hartman > > Reviewed-by: Michael Kelley > > Link: https://lore.kernel.org/r/20211126023316.25184-1-rdunlap@infradead.org > > Signed-off-by: Wei Liu > > Cc: Petr Štetiar > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/hv/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > --- a/drivers/hv/Kconfig > > +++ b/drivers/hv/Kconfig > > @@ -17,6 +17,7 @@ config HYPERV_TIMER > > config HYPERV_UTILS > > tristate "Microsoft Hyper-V Utilities driver" > > depends on HYPERV && CONNECTOR && NLS > > + depends on PTP_1588_CLOCK_OPTIONAL > > AFAICT PTP_1588_CLOCK_OPTIONAL does not exist in 5.4 kernels, > so this should not be used there. Gotta love it when people lie in Fixes: tags :( I'll go drop this, thanks! greg k-h