From: Greg KH <gregkh@linuxfoundation.org>
To: Khazhismel Kumykov <khazhy@google.com>
Cc: stable@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Chaitanya Kulkarni <kch@nvidia.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block/compat_ioctl: fix range check in BLKGETSIZE
Date: Thu, 21 Apr 2022 12:02:25 +0200 [thread overview]
Message-ID: <YmErsSY45MQu/Ks4@kroah.com> (raw)
In-Reply-To: <20220419191239.588421-1-khazhy@google.com>
On Tue, Apr 19, 2022 at 12:12:39PM -0700, Khazhismel Kumykov wrote:
> [ Upstream commit ccf16413e520164eb718cf8b22a30438da80ff23 ]
>
> kernel ulong and compat_ulong_t may not be same width. Use type directly
> to eliminate mismatches.
>
> This would result in truncation rather than EFBIG for 32bit mode for
> large disks.
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> Link: https://lore.kernel.org/r/20220414224056.2875681-1-khazhy@google.com
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> [compat_ioctl is it's own file in 5.4-stable and earlier]
> ---
>
> The original commit should apply to the newer stables
It does not, it only applied to 5.17.y.
Please provide working backports for all of the others.
> this should apply
> to all the older stables.
I'll wait for the 5.10.y and 5.15.y backport first before applying this
one.
thanks,
greg k-h
next prev parent reply other threads:[~2022-04-21 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 19:12 [PATCH] block/compat_ioctl: fix range check in BLKGETSIZE Khazhismel Kumykov
2022-04-21 10:02 ` Greg KH [this message]
2022-04-25 19:29 ` Khazhy Kumykov
2022-04-26 6:39 ` Greg KH
2022-04-25 19:27 ` [PATCH v5.10] " Khazhismel Kumykov
2022-04-25 19:27 ` [PATCH v5.15] " Khazhismel Kumykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmErsSY45MQu/Ks4@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=kch@nvidia.com \
--cc=khazhy@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox