From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3082C433EF for ; Wed, 4 May 2022 21:28:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347336AbiEDVc2 (ORCPT ); Wed, 4 May 2022 17:32:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347126AbiEDVc1 (ORCPT ); Wed, 4 May 2022 17:32:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F27750E0B; Wed, 4 May 2022 14:28:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3BCD561967; Wed, 4 May 2022 21:28:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A0B2C385A4; Wed, 4 May 2022 21:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651699729; bh=k/SHTcjQ/PrI0QjQFYZgO+ymU5S0yqAqGxV95jD8MsQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AdVKX9QSdZLa7TIJ3yvhHLml7315UPHCfxhawSuffcCTBVJotbhWHUzsROHlu2O5e jPAZTuP4dm5QjDRzuEWnuSnugpo1wvvQtnrPNzLgJIyuOX+vtX94qcN0DwtZf8U4/m ZBaXw3Hihi4m/X8rhkruZupoD+MYwjUK2HyN9s/HTQizW9b+zi6E3xpx6utfeTDtK/ Y66zF313//wPDhubvYbZGAlRpalOIzlLj2APkEM2lAU3mSTGcbcJD9XZbqCXuRxn6x aXN4sHCVprdCf8uqq5ZDKQVixCM/+1Sh+YwzhAlpEPuNESC2X6aSnBfPlnoWXUWdzj 0FnwTqPfzpeyA== Date: Wed, 4 May 2022 14:28:47 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ming Yan , Chao Yu Subject: Re: [PATCH] f2fs: fix to do sanity check for inline inode Message-ID: References: <20220428024940.12102-1-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220428024940.12102-1-chao@kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 04/28, Chao Yu wrote: > As Yanming reported in bugzilla: > > https://bugzilla.kernel.org/show_bug.cgi?id=215895 > > I have encountered a bug in F2FS file system in kernel v5.17. > > The kernel message is shown below: > > kernel BUG at fs/inode.c:611! > Call Trace: > evict+0x282/0x4e0 > __dentry_kill+0x2b2/0x4d0 > dput+0x2dd/0x720 > do_renameat2+0x596/0x970 > __x64_sys_rename+0x78/0x90 > do_syscall_64+0x3b/0x90 > > The root cause is: fuzzed inode has both inline_data flag and encrypted > flag, so after it was deleted by rename(), during f2fs_evict_inode(), > it will cause inline data conversion due to flags confilction, then > page cache will be polluted and trigger panic in clear_inode(). > > This patch tries to fix the issue by do more sanity checks for inline > data inode in sanity_check_inode(). > > Cc: stable@vger.kernel.org > Reported-by: Ming Yan > Signed-off-by: Chao Yu > --- > fs/f2fs/f2fs.h | 7 +++++++ > fs/f2fs/inode.c | 3 +-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 27aa93caec06..64c511b498cc 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -4173,6 +4173,13 @@ static inline void f2fs_set_encrypted_inode(struct inode *inode) > */ > static inline bool f2fs_post_read_required(struct inode *inode) > { > + /* > + * used by sanity_check_inode(), when disk layout fields has not > + * been synchronized to inmem fields. > + */ > + if (file_is_encrypt(inode) || file_is_verity(inode) || > + F2FS_I(inode)->i_flags & F2FS_COMPR_FL) > + return true; > return f2fs_encrypted_file(inode) || fsverity_active(inode) || > f2fs_compressed_file(inode); > } > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 83639238a1fe..234b8ed02644 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -276,8 +276,7 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) > } > } > > - if (f2fs_has_inline_data(inode) && > - (!S_ISREG(inode->i_mode) && !S_ISLNK(inode->i_mode))) { > + if (f2fs_has_inline_data(inode) && !f2fs_may_inline_data(inode)) { It seems f2fs_may_inline_data() is breaking the atomic write case. Please fix. > set_sbi_flag(sbi, SBI_NEED_FSCK); > f2fs_warn(sbi, "%s: inode (ino=%lx, mode=%u) should not have inline_data, run fsck to fix", > __func__, inode->i_ino, inode->i_mode); > -- > 2.25.1