* [PATCH] platform/x86: intel-hid: fix _DSM function index handling
@ 2022-05-16 10:23 Michael Niewöhner
2022-05-16 11:44 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Michael Niewöhner @ 2022-05-16 10:23 UTC (permalink / raw)
To: Alex Hung, Hans de Goede, Mark Gross, platform-driver-x86,
linux-kernel, stable
intel_hid_dsm_fn_mask is a bit mask containing one bit for each function
index. Fix the function index check in intel_hid_evaluate_method
accordingly, which was missed in commit 97ab4516205e ("platform/x86:
intel-hid: fix _DSM function index handling").
Signed-off-by: Michael Niewöhner <linux@mniewoehner.de>
---
drivers/platform/x86/intel/hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
index 13f8cf70b9ae..5c39d40a701b 100644
--- a/drivers/platform/x86/intel/hid.c
+++ b/drivers/platform/x86/intel/hid.c
@@ -238,7 +238,7 @@ static bool intel_hid_evaluate_method(acpi_handle handle,
method_name = (char *)intel_hid_dsm_fn_to_method[fn_index];
- if (!(intel_hid_dsm_fn_mask & fn_index))
+ if (!(intel_hid_dsm_fn_mask & BIT(fn_index)))
goto skip_dsm_eval;
obj = acpi_evaluate_dsm_typed(handle, &intel_dsm_guid,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86: intel-hid: fix _DSM function index handling
2022-05-16 10:23 [PATCH] platform/x86: intel-hid: fix _DSM function index handling Michael Niewöhner
@ 2022-05-16 11:44 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-05-16 11:44 UTC (permalink / raw)
To: Michael Niewöhner
Cc: Alex Hung, Hans de Goede, Mark Gross, platform-driver-x86,
linux-kernel, stable
On Mon, May 16, 2022 at 12:23:22PM +0200, Michael Niewöhner wrote:
> intel_hid_dsm_fn_mask is a bit mask containing one bit for each function
> index. Fix the function index check in intel_hid_evaluate_method
> accordingly, which was missed in commit 97ab4516205e ("platform/x86:
> intel-hid: fix _DSM function index handling").
>
> Signed-off-by: Michael Niewöhner <linux@mniewoehner.de>
> ---
> drivers/platform/x86/intel/hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 13f8cf70b9ae..5c39d40a701b 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -238,7 +238,7 @@ static bool intel_hid_evaluate_method(acpi_handle handle,
>
> method_name = (char *)intel_hid_dsm_fn_to_method[fn_index];
>
> - if (!(intel_hid_dsm_fn_mask & fn_index))
> + if (!(intel_hid_dsm_fn_mask & BIT(fn_index)))
> goto skip_dsm_eval;
>
> obj = acpi_evaluate_dsm_typed(handle, &intel_dsm_guid,
> --
> 2.34.1
>
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-16 10:23 [PATCH] platform/x86: intel-hid: fix _DSM function index handling Michael Niewöhner
2022-05-16 11:44 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox