public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: MMIO support for I2C-PIIX4 and SP5100-TCO
Date: Wed, 18 May 2022 21:25:24 +0200	[thread overview]
Message-ID: <YoVIJB/d8Ei3iJiE@kroah.com> (raw)
In-Reply-To: <MN0PR12MB610150AC5F1E15D6A67AC352E2D19@MN0PR12MB6101.namprd12.prod.outlook.com>

On Wed, May 18, 2022 at 06:49:59PM +0000, Limonciello, Mario wrote:
> [Public]
> 
> Hi,
> 
> Some users have complained that i2c the controller doesn't work on newer designs.  This is because the system can be configured by an OEM to not allow access to the I2C controller registers via legacy methods and instead requires MMIO.
> 
> Some bug reports collecting this problem (which have had duplicates brought in)
> https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/1984
> https://bugs.launchpad.net/amd/+bug/1950062
> 
> These commits that have landed into 5.18 fix this issue both for i2c-piix4 and for sp5100-tco (which suffers the same fate).
> 
> Would you take them back to stable 5.15.y and 5.17.y?  The series comes back cleanly to both.
> 
> 27c196c7b73c kernel/resource: Introduce request_mem_region_muxed()
> 93102cb44978 i2c: piix4: Replace hardcoded memory map size with a #define
> a3325d225b00 i2c: piix4: Move port I/O region request/release code into functions
> 0a59a24e14e9 i2c: piix4: Move SMBus controller base address detect into function
> fbafbd51bff5 i2c: piix4: Move SMBus port selection into function
> 7c148722d074 i2c: piix4: Add EFCH MMIO support to region request and release
> 46967bc1ee93 i2c: piix4: Add EFCH MMIO support to SMBus base address detect
> 381a3083c674 i2c: piix4: Add EFCH MMIO support for SMBus port select
> 6cf72f41808a i2c: piix4: Enable EFCH MMIO for Family 17h+
> abd71a948f7a Watchdog: sp5100_tco: Move timer initialization into function
> 1f182aca2300 Watchdog: sp5100_tco: Refactor MMIO base address initialization
> 0578fff4aae5 Watchdog: sp5100_tco: Add initialization using EFCH MMIO
> 826270373f17 Watchdog: sp5100_tco: Enable Family 17h+ CPUs

What is the overall diffstat of all of these commits applied?  And why
can't people with newer hardware just use 5.18 and newer releases like
they do for other more complex hardware additions?

thanks,

greg k-h

  reply	other threads:[~2022-05-18 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 18:49 MMIO support for I2C-PIIX4 and SP5100-TCO Limonciello, Mario
2022-05-18 19:25 ` Greg KH [this message]
2022-05-18 19:35   ` Limonciello, Mario
2022-05-19 12:50     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoVIJB/d8Ei3iJiE@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Mario.Limonciello@amd.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox