From: Greg KH <gregkh@linuxfoundation.org>
To: Denis Efremov <denis.e.efremov@oracle.com>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
dan.carpenter@oracle.com, straube.linux@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] staging: r8188eu: prevent ->Ssid overflow in rtw_wx_set_scan()
Date: Thu, 19 May 2022 17:40:13 +0200 [thread overview]
Message-ID: <YoZk3YLEDYKGG5xe@kroah.com> (raw)
In-Reply-To: <855d90d7-70a2-da82-d62c-e8c030411852@oracle.com>
On Wed, May 18, 2022 at 11:49:27AM +0400, Denis Efremov wrote:
>
>
> On 5/18/22 11:00, Denis Efremov wrote:
> > This code has a check to prevent read overflow but it needs another
> > check to prevent writing beyond the end of the ->Ssid[] array.
> >
> > Fixes: 2b42bd58b321 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver")
> > Cc: stable <stable@vger.kernel.org>
> > Signed-off-by: Denis Efremov <denis.e.efremov@oracle.com>
> > ---
> >
> > This patch is a copy of Dan's 74b6b20df8cf (CVE-2021-28660).
> > Drivers r8188eu and rtl8188eu share the same code.
>
> I also found same code pattern in rtl8723bs driver in
> stable kernels 5.10, 5.4, 4.19, 4.14.
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c?h=linux-5.10.y#n1354
> I can send the same fix to stable trees if appropriate.
Please do!
thanks,
greg k-h
next prev parent reply other threads:[~2022-05-19 15:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YEHymwsnHewzoam7@mwanda>
2022-05-18 7:00 ` [PATCH] staging: r8188eu: prevent ->Ssid overflow in rtw_wx_set_scan() Denis Efremov
2022-05-18 7:49 ` Denis Efremov
2022-05-19 15:40 ` Greg KH [this message]
2022-05-20 3:57 ` [PATCH v5.10] staging: rtl8723bs: " Denis Efremov (Oracle)
2022-05-23 15:26 ` Greg KH
2022-05-23 17:41 ` Denis Efremov
2022-05-26 12:05 ` Greg KH
2022-05-23 17:39 ` [PATCH v5.4-v4.14] " Denis Efremov (Oracle)
2022-05-19 15:45 ` [PATCH] staging: r8188eu: " Greg KH
2022-05-19 17:16 ` Dan Carpenter
2022-05-19 17:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoZk3YLEDYKGG5xe@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=denis.e.efremov@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=stable@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox