Re: [PATCH] net: stmmac: disable Split Header (SPH) for Intel platforms

[Greg KH <greg@kroah.com>]

On Mon, May 23, 2022 at 09:39:10AM +0800, Tan Tee Min wrote:
> commit 47f753c1108e287edb3e27fad8a7511a9d55578e upstream.
> 
> Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation
> of Split Header (SPH) feature is not supported for Ipv4 fragmented packet.
> This SPH limitation will cause ping failure when the packets size exceed
> the MTU size. For example, the issue happens once the basic ping packet
> size is larger than the configured MTU size and the data is lost inside
> the fragmented packet, replaced by zeros/corrupted values, and leads to
> ping fail.
> 
> So, disable the Split Header for Intel platforms.
> 
> v2: Add fixes tag in commit message.
> 
> Fixes: 67afd6d1cfdf("net: stmmac: Add Split Header support and enable it in XGMAC cores")
> Cc: <stable@vger.kernel.org> # 5.4.x
> Suggested-by: Ong, Boon Leong <boon.leong.ong@intel.com>
> Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
> Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>  drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c  | 1 +
>  include/linux/stmmac.h                            | 1 +
>  3 files changed, 3 insertions(+), 1 deletion(-)

Now queued up, thanks.

greg k-h